Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute performance tests in dry-run mode in PR CI #130287

Closed
spalger opened this issue Apr 14, 2022 · 3 comments
Closed

Execute performance tests in dry-run mode in PR CI #130287

spalger opened this issue Apr 14, 2022 · 3 comments
Assignees
Labels
Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Apr 14, 2022

The performance tests are not currently running on CI because we don't get reliable performance metrics from them. Unfortunately this means that manual testing is required to know if a PR is going to break the performance tests after it's merged. We didn't do that with #129464 and it broke a few things, so I think we should add a single run of these tests in some sort of alternate mode that makes sure the execute but doesn't influence the metrics we're collecting. Thoughts @suchcodemuchwow?

@spalger spalger added the Team:Operations Team label for Operations Team label Apr 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

spalger pushed a commit that referenced this issue Apr 14, 2022
@suchcodemuchwow
Copy link
Contributor

I believe we can create a new build that does run on PR's whenever we change something on performance related files and folders it can be a bit over defensive approach but we can guarantee the metrics are not polluted because of something breaking.

@suchcodemuchwow
Copy link
Contributor

This issue is resolved by this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

3 participants