Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing axios from data_view_field_editor test #129116

Merged
merged 9 commits into from
Apr 11, 2022
Merged

Removing axios from data_view_field_editor test #129116

merged 9 commits into from
Apr 11, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Mar 31, 2022 •
edited
Loading

Summary

Remove axios dependency, use service mock instead.

Closes #127965

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Apr 8, 2022
@mattkime mattkime marked this pull request as ready for review April 8, 2022 13:32
@mattkime mattkime requested a review from a team as a code owner April 8, 2022 13:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime
Copy link
Contributor Author

mattkime commented Apr 8, 2022

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattkime mattkime merged commit ae39e1b into elastic:main Apr 11, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 11, 2022
@mattkime mattkime added v7.17.3 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Apr 11, 2022
@azasypkin azasypkin mentioned this pull request Apr 11, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 129116

Questions ?

Please refer to the Backport tool documentation

mattkime added a commit to mattkime/kibana that referenced this pull request Apr 11, 2022
@mattkime
Removing axios from data_view_field_editor test (elastic#129116)
68d002f 
* test bed fixes
Co-authored-by: Kibana Machine <[email protected]>

(cherry picked from commit ae39e1b)

# Conflicts:
#	src/plugins/data_view_field_editor/__jest__/client_integration/field_editor.test.tsx
#	src/plugins/data_view_field_editor/__jest__/client_integration/field_editor_flyout_content.test.ts
#	src/plugins/data_view_field_editor/__jest__/client_integration/field_editor_flyout_preview.test.ts
#	src/plugins/data_view_field_editor/__jest__/client_integration/helpers/setup_environment.tsx
@mattkime mattkime mentioned this pull request Apr 11, 2022
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 12, 2022
mattkime added a commit that referenced this pull request Apr 13, 2022
@mattkime
[7.17] Removing axios from data_view_field_editor test (#129116) (#12…
a80fc36 
…9952)

* Removing axios from data_view_field_editor test  (#129116)

* test bed fixes
Co-authored-by: Kibana Machine <[email protected]>

(cherry picked from commit ae39e1b)

# Conflicts:
#	src/plugins/data_view_field_editor/__jest__/client_integration/field_editor.test.tsx
#	src/plugins/data_view_field_editor/__jest__/client_integration/field_editor_flyout_content.test.ts
#	src/plugins/data_view_field_editor/__jest__/client_integration/field_editor_flyout_preview.test.ts
#	src/plugins/data_view_field_editor/__jest__/client_integration/helpers/setup_environment.tsx

* better match main pr

* fix integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.17.3 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of axios dependency in the data_view_field_editor tests.
5 participants
@mattkime @elasticmachine @kibana-ci @kibanamachine @Dosant