Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of axios dependency in the data_view_field_editor tests. #127965

Closed
azasypkin opened this issue Mar 17, 2022 · 0 comments · Fixed by #129116
Closed

Get rid of axios dependency in the data_view_field_editor tests. #127965

azasypkin opened this issue Mar 17, 2022 · 0 comments · Fixed by #129116
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:Operations NeededFor:Security technical debt Improvement of the software architecture and operational architecture triage_needed

Comments

@azasypkin
Copy link
Member

Summary

In #111655 (comment) we're trying to upgrade axios package, but are blocked because of the following axios usage in the tests (axios just happened to have methods signature similar to HttpSetup, but it's technically incorrect and quite fragile):

🚫 const httpSetup = axios.create({ adapter: axiosXhrAdapter }) as unknown as HttpSetup; 🚫

The path forward is to switch tests to use HttpSetup mock instead of axios + sinon server mock. There is an example and reference implementation in the Upgrade Assistant tests, see this pull request.

If you have any questions or don't have enough capacity to update the tests, please ping me and I'll try to help out.

IMPORTANT: we have to backport axios upgrade to 7.17.x and hence updated tests should be backported to the 7.17 branch as well.
@azasypkin azasypkin added technical debt Improvement of the software architecture and operational architecture Team:AppServicesSv NeededFor:Security NeededFor:Operations triage_needed labels Mar 17, 2022
@azasypkin azasypkin mentioned this issue Mar 17, 2022
Merged
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 18, 2022
@mattkime mattkime mentioned this issue Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:Operations NeededFor:Security technical debt Improvement of the software architecture and operational architecture triage_needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing axios from data_view_field_editor test mattkime/kibana
1 participant
@azasypkin