-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status filter #128343
Status filter #128343
Conversation
…ge_read_permissions
💔 Build FailedFailed CI StepsTest FailuresMetrics [docs]Module Count
Async chunks
Page load bundle
HistoryTo update your PR or re-run it, just comment with: |
@@ -39,6 +45,7 @@ export function useFetchRules({ searchText, ruleLastResponseFilter, page, sort } | |||
searchText, | |||
typesFilter: OBSERVABILITY_RULE_TYPES, | |||
ruleStatusesFilter: ruleLastResponseFilter, | |||
ruleStatusFilter: [false], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hardcoded here just for testing. ruleStatusFilter at the moment is an array of strings for example ['enabled', 'disabled'], but alert.attributes.enabled
is a boolean, so these values need to be converted to booleans.
With the newly added snoozed status, the logic needs to be changed, that's why I didn't proceed further and hardcoded some boolean value to see it working just for enabled and disabled. This implementation will definitely change.
Closing this one in favor of this #131219 |
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers