Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status filter #128343

Closed
wants to merge 18 commits into from
Closed

Status filter #128343

wants to merge 18 commits into from

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Mar 23, 2022

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 23, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Default Accessibility Tests / Maps app meets ally validations single cancel modal

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 379 382 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 414.8KB 418.8KB +4.1KB
triggersActionsUi 663.2KB 663.2KB +7.0B
total +4.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 89.7KB 89.8KB +52.0B
triggersActionsUi 96.6KB 96.9KB +302.0B
total +354.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@@ -39,6 +45,7 @@ export function useFetchRules({ searchText, ruleLastResponseFilter, page, sort }
searchText,
typesFilter: OBSERVABILITY_RULE_TYPES,
ruleStatusesFilter: ruleLastResponseFilter,
ruleStatusFilter: [false],
Copy link
Contributor Author

@mgiota mgiota Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hardcoded here just for testing. ruleStatusFilter at the moment is an array of strings for example ['enabled', 'disabled'], but alert.attributes.enabled is a boolean, so these values need to be converted to booleans.

With the newly added snoozed status, the logic needs to be changed, that's why I didn't proceed further and hardcoded some boolean value to see it working just for enabled and disabled. This implementation will definitely change.

@mgiota
Copy link
Contributor Author

mgiota commented Apr 29, 2022

Closing this one in favor of this #131219

@mgiota mgiota closed this Apr 29, 2022
@mgiota mgiota deleted the status_filter branch September 29, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants