-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Log data tables properly #128297
[Lens] Log data tables properly #128297
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maps changes LGTM
code review, tested in chrome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugs fixed and changes LGTM, I tested in both Lens and Viz Editor. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a bug for a heatmap, there's no data displayed (somehow there's pagination though):
Before:
Also, not introduced by this PR, but with a default include empty rows
setting there's a lot of data user doesn't probably need because it's empty (you can see it in before pic). I wonder if we could do something about it? 🤔
@mbondyra Good catch with the heatmap, should be fixed now.
Right, I think it's OK though - consistency seems more important to me than empty rows in this table which are probably easy to handle anyway downstream (e.g. Excel). Also for real world data it's probably not that big of a problem (it tends to have way less gaps especially for things the user wants to export) |
@elasticmachine merge upstream |
Fixed the annotations case |
All works as expected, approved 🆗 |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Fixes #127995
Fixes #121063
Log data tables properly in all cases so additional columns do not show up and the region map table is logged correct as well.