[responseOps] add snoozing MVP in alerting framework #127694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
pmuellr
force-pushed
the
alerting/126512-snooze-impl
branch
2 times, most recently
from
99f8ce6 to
e45b79f
Compare
pmuellr
added
release_note:skip
resolves elastic#126512 Changes the calculation of rule-level muting to take into account snoozeEndTime. If muteAll is true, the rule is considered snoozing forever, regardless of the setting of snoozeEndTime. If muteAll is false, snoozeEndTime determines whether the rule is snoozed. If snoozeEndTime is null, the rule is not snoozed. Otherwise, snoozeEndTime is a Date, and if it's >= than Date.now(), the rule is snoozed. Otherwise, the rule is not snoozed.
pmuellr
force-pushed
the
alerting/126512-snooze-impl
branch
from
045937d to
99f5e68
Compare
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
LGTM! Nice job :)
Verified by:
- creating an Always Firing rule with server log action
- snoozing via API with snooze_end_time and verifying that no actions were written until snooze_end_time has passed
- snoozing via API with snooze_end_time = -1 and verifying that no actions were written until setting unmuting via API
|
@elasticmachine merge upstream |
XavierM
approved these changes
Mar 24, 2022
mikecote
approved these changes
Mar 24, 2022
| expect(connStatus).to.be(200); | ||
| objectRemover.add(Spaces.space1.id, createdAction.id, 'action', 'actions'); | ||
|
|
||
| log.info('creating rule'); |
There was a problem hiding this comment.
question: should these logs be info or debug? I believe CI used to or still captures the debug logs whenever a flaky or failed test happens.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #126512
Changes the calculation of rule-level muting to take into account snoozeEndTime.
If muteAll is true, the rule is considered snoozing forever, regardless of the setting of snoozeEndTime.
If muteAll is false, snoozeEndTime determines whether the rule is snoozed. If snoozeEndTime is null, the rule is not snoozed. Otherwise, snoozeEndTime is a Date, and if it's >= than Date.now(), the rule is snoozed. Otherwise, the rule is not snoozed.
this PR branch was originally based off of #127081
testing locally
To test, create a rule that is firing all the time that you can check - using server log is usually the easiest. Use a 1s interval so you will see the effect quicker.
To set a snooze, use the following curl command:
Note the time value should be an ISO date - using a Z at the end implies UTC, without a Z, assumes local.
You can also use the value -1 (not a string) which functions the same as "mute all".
To "unsnooze", currently you have to use "unmute all":
Checklist
Delete any items that are not applicable to this PR.