only call isRuleSnoozed() once; from PR review

elastic · Mar 23, 2022 · d865d70 · d865d70
1 parent 99f5e68
commit d865d70
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/x-pack/plugins/alerting/server/task_runner/task_runner.ts b/x-pack/plugins/alerting/server/task_runner/task_runner.ts
@@ -487,7 +487,8 @@ export class TaskRunner<
       triggeredActionsStatus: ActionsCompletion.COMPLETE,
     };
 
-    if (!this.isRuleSnoozed(rule) && this.shouldLogAndScheduleActionsForAlerts()) {
+    const ruleIsSnoozed = this.isRuleSnoozed(rule);
+    if (!ruleIsSnoozed && this.shouldLogAndScheduleActionsForAlerts()) {
       const mutedAlertIdsSet = new Set(mutedInstanceIds);
 
       const alertsWithExecutableActions = Object.entries(alertsWithScheduledActions).filter(
@@ -538,7 +539,7 @@ export class TaskRunner<
         alertExecutionStore,
       });
     } else {
-      if (this.isRuleSnoozed(rule)) {
+      if (ruleIsSnoozed) {
         this.logger.debug(`no scheduling of actions for rule ${ruleLabel}: rule is snoozed.`);
       }
       if (!this.shouldLogAndScheduleActionsForAlerts()) {