Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Show chart tooltip on hover even for empty buckets #127665

Merged
merged 2 commits into from
Mar 15, 2022
Merged

[APM] Show chart tooltip on hover even for empty buckets #127665

merged 2 commits into from
Mar 15, 2022

Conversation

cauemarcondes
Copy link
Contributor

closes #85793

tooltip.mov

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 14, 2022
@cauemarcondes cauemarcondes requested a review from a team as a code owner March 14, 2022 20:53
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes requested a review from formgeist March 14, 2022 20:53
graphaelli
graphaelli approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@graphaelli graphaelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant

@cauemarcondes
Copy link
Contributor Author

Screen Shot 2022-03-14 at 5 53 48 PM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +36.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@formgeist formgeist mentioned this pull request Mar 15, 2022
Closed
@cauemarcondes cauemarcondes added the backport:skip This commit does not require backporting label Mar 15, 2022
@cauemarcondes cauemarcondes merged commit 63caa0e into elastic:main Mar 15, 2022
@cauemarcondes cauemarcondes deleted the apm-show-tooltip-null-value branch March 15, 2022 13:32
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@cauemarcondes @maksimkovalev
[APM] Show chart tooltip on hover even for empty buckets (elastic#127665
014bcb7 
)

* show tooltip when null

* showNullValues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@graphaelli graphaelli graphaelli approved these changes

@formgeist formgeist Awaiting requested review from formgeist

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Show chart tooltip on hover even for empty buckets
5 participants
@cauemarcondes @elasticmachine @kibana-ci @graphaelli @sorenlouv