Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Show chart tooltip on hover even for empty buckets #85793

Closed
formgeist opened this issue Dec 14, 2020 · 9 comments · Fixed by #127665
Closed

[APM] Show chart tooltip on hover even for empty buckets #85793

formgeist opened this issue Dec 14, 2020 · 9 comments · Fixed by #127665
Labels
apm:charts apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Dec 14, 2020

Summary

Related charts fix elastic/elastic-charts#950

We should default to show the tooltip at all times and display N/A in the time-series value if the bucket is empty (not 0).

102099179-5031ff80-3e28-11eb-8252-70d44543f643

Example hover interaction

Kapture 2020-12-15 at 10 14 27

@formgeist formgeist added the Team:APM All issues that need APM UI Team support label Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith added [zube]: Inbox bug Fixes for quality problems that affect the customer experience apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts labels Dec 14, 2020
@smith smith assigned smith and formgeist and unassigned smith Dec 14, 2020
@formgeist
Copy link
Contributor Author

@elastic/elastic-charts Pinging you here, but do you already have something in place that enables us to show the tooltip even if there's no available values for the bucket, like here in the case where we're syncing the tooltip, but one chart doesn't have any data in some areas. Or do you think this is a possible enhancement, then I'm happy to create a new issue in the charts repo.

Thanks

@markov00
Copy link
Member

markov00 commented Dec 15, 2020

You are right, when there is no datapoint, the tooltip is not shown, we can add an option to show always the tooltip + a customizable message in this case.
Yes please open an issue in the chart repo and link this one, thanks

@formgeist
Copy link
Contributor Author

@markov00 Great, I've opened a charts issue for adding such option elastic/elastic-charts#950

@formgeist
Copy link
Contributor Author

This issue has been resolved by the charts team elastic/elastic-charts#950

@formgeist formgeist removed their assignment Sep 9, 2021
@botelastic
Copy link

botelastic bot commented Mar 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Mar 8, 2022
@botelastic botelastic bot removed the stale Used to mark issues that were closed for being stale label Mar 8, 2022
@formgeist
Copy link
Contributor Author

Verified that we're still not showing the synced tooltip for "n/a" values

CleanShot 2022-03-14 at 16 27 19@2x

@markov00
Copy link
Member

Verified that we're still not showing the synced tooltip for "n/a" values

Just to be clear, this behaviour needs to be activated on your hand, is not available by default in charts, see elastic/elastic-charts#1226

@formgeist
Copy link
Contributor Author

@markov00 Thanks for clarifying, my comment was just an internal note for the team that the issue was still there - @cauemarcondes has already created a PR to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:charts apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants