-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add disabled filters when show underlying data #127253
[Lens] Add disabled filters when show underlying data #127253
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected, LGTM
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
This PR is a follow up from #125983 based on this comment.
The idea is to show in Discover ignored filters as disabled filters to help the user explore subsets of the data using defined contexts in the visualization.
As an example imagine the following chart:
In such configuration
Count of Records
>Count of Records with filter
, therefore the filter would be ignored for the wider scope. With #125983 such ignored filter will be discarded and that context would be lost for the user.With this PR instead the filter will be carried over to Discover in a disabled state, allowing the user to toggle it for inner investigations:
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers