Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add disabled filters when show underlying data #127253

Merged
merged 49 commits into from
Mar 17, 2022

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Mar 9, 2022

Summary

This PR is a follow up from #125983 based on this comment.

The idea is to show in Discover ignored filters as disabled filters to help the user explore subsets of the data using defined contexts in the visualization.

As an example imagine the following chart:

Screenshot 2022-03-09 at 10 14 43

In such configuration Count of Records > Count of Records with filter, therefore the filter would be ignored for the wider scope. With #125983 such ignored filter will be discarded and that context would be lost for the user.
With this PR instead the filter will be carried over to Discover in a disabled state, allowing the user to toggle it for inner investigations:

Screenshot 2022-03-09 at 10 14 55

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

dej611 and others added 30 commits February 15, 2022 09:54
@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.2.0 labels Mar 9, 2022
@dej611
Copy link
Contributor Author

dej611 commented Mar 9, 2022

@elasticmachine merge upstream

@dej611 dej611 added the release_note:skip Skip the PR/issue when compiling release notes label Mar 10, 2022
@dej611 dej611 marked this pull request as ready for review March 10, 2022 08:27
@dej611 dej611 requested a review from a team as a code owner March 10, 2022 08:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@dej611
Copy link
Contributor Author

dej611 commented Mar 16, 2022

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@flash1293 flash1293 enabled auto-merge (squash) March 17, 2022 10:39
@flash1293 flash1293 merged commit 7c07124 into elastic:main Mar 17, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +389.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants