[App Search] Add EuiThemeProvider to fix crashing bug
#124993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the LogStream component and it was broken after implementing KibanaThemeProvider. The fix is to re-introduce EuiThemeProvider as a wrapper around the component that uses styled-components
scottybollinger
added
bug
This is a plugin component that we do not support so I had to jump through some hoops to get the assertions to pass.
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 9, 2022
(cherry picked from commit 449f8e6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 9, 2022
…25086) (cherry picked from commit 449f8e6) Co-authored-by: Scotty Bollinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/elastic/enterprise-search-team/issues/1013
Summary
We use the
LogStreamcomponent, usesstyled-components, and it was broken after implementingKibanaThemeProvider. The fix is to re-introduceEuiThemeProvideras a wrapper around the component that usesstyled-components.Before
before.mp4
After
after.mp4