Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Replace EuiThemeProvider with KibanaThemeProvider #120244

Merged
merged 1 commit into from
Dec 2, 2021
Merged

[Enterprise Search] Replace EuiThemeProvider with KibanaThemeProvider #120244

merged 1 commit into from
Dec 2, 2021

Conversation

scottybollinger
Copy link
Contributor

In pursuit of #118866

Summary

Replaces EuiThemeProvider with KibanaThemeProvider

@scottybollinger scottybollinger added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Dec 2, 2021
@scottybollinger
Copy link
Contributor Author

scottybollinger commented Dec 2, 2021 •
edited
Loading

@pgayvallet would you mind making sure this looks correct? I am assuming we can drop EuiThemeProvider and do not need both theme providers. Is this correct?

EDIT. I see it's calling it here. Sorry for the ping

@scottybollinger scottybollinger marked this pull request as ready for review December 2, 2021 17:07
@scottybollinger scottybollinger requested a review from a team December 2, 2021 17:07
@scottybollinger scottybollinger mentioned this pull request Dec 2, 2021
Closed
@scottybollinger scottybollinger changed the title Replace EuiThemeProvider with KibanaThemeProvider [Enterprise Search] Replace EuiThemeProvider with KibanaThemeProvider Dec 2, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +3.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 16.2KB 16.1KB -141.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 44f3f92 into elastic:main Dec 2, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@scottybollinger @TinLe
Replace EuiThemeProvider with KibanaThemeProvider (elastic#120244)
0b4f5bc
@scottybollinger scottybollinger mentioned this pull request Feb 8, 2022
Merged
@scottybollinger scottybollinger deleted the scottybollinger/theme-provider branch March 15, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonStoltz JasonStoltz JasonStoltz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottybollinger @kibana-ci @JasonStoltz