Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix Data visualizer navigation to Lens broken due to records field migration #124376

Closed
wants to merge 1 commit into from

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 2, 2022

Summary

This PR fixes an issue that was introduced after Lens's format for the records fields were updated #123894.

Checklist

Delete any items that are not applicable to this PR.

@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Feb 2, 2022
@qn895 qn895 requested a review from a team as a code owner February 2, 2022 16:45
@qn895 qn895 self-assigned this Feb 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 force-pushed the dv-fix-records-field-lens branch 2 times, most recently from 07073d9 to c696100 Compare February 2, 2022 17:01
@qn895 qn895 force-pushed the dv-fix-records-field-lens branch from c696100 to 248cba5 Compare February 2, 2022 17:11
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #10 / maps app geo file upload shapefile upload should preview part of shapefile

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 539.8KB 539.9KB +60.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 16.6KB 16.8KB +144.0B

History

  • 💔 Build #21388 failed 07073d9f5a8581b8a56d20d1f79f04fdbfd2bfa1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 3, 2022
@qn895
Copy link
Member Author

qn895 commented Feb 3, 2022

Closing this PR in favor of this #124276

@qn895 qn895 closed this Feb 3, 2022
@qn895 qn895 deleted the dv-fix-records-field-lens branch February 7, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants