Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix records field name and migrate #123894

Merged

Conversation

flash1293
Copy link
Contributor

Fixes #123824

This renames the name of the virtual "document" field to ___records___ - this shoudn't change the UI in any way as the display name stays i18n-ified. The weird name is chosen to make it unlikely to collide with actual user-supplied field names (Records wasn't a great choice for that).

To test manually:

  • Create a Lens vis using the records field, save it, then switch localization (e.g. i18n.locale: zn-CN) - vis should still load
  • Lens visualizations in sample data should work regardless in which language they were installed vs. in which they are viewed
  • Old existing Lens visualizations work fine regardless of the language

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.1.0 labels Jan 27, 2022
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@flash1293 flash1293 marked this pull request as ready for review January 27, 2022 14:57
@flash1293 flash1293 requested a review from a team as a code owner January 27, 2022 14:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 253 254 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.0MB 1.0MB -21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 41.5KB 41.6KB +70.0B
Unknown metric groups

API count

id before after diff
lens 275 276 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit fabaa88 into elastic:main Jan 31, 2022
adriansr added a commit to adriansr/beats that referenced this pull request Feb 10, 2022
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana
that didn't include this change:

elastic/kibana#123894

After this change was merged, most visualisations in the dashboard
stopped working.

This doesn't affect older dashboards as those are migrated automatically
from an older version.
adriansr added a commit to elastic/beats that referenced this pull request Feb 10, 2022
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana
that didn't include this change:

elastic/kibana#123894

After this change was merged, most visualisations in the dashboard
stopped working.

This doesn't affect older dashboards as those are migrated automatically
from an older version.
mergify bot pushed a commit to elastic/beats that referenced this pull request Feb 10, 2022
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana
that didn't include this change:

elastic/kibana#123894

After this change was merged, most visualisations in the dashboard
stopped working.

This doesn't affect older dashboards as those are migrated automatically
from an older version.

(cherry picked from commit a84c26e)
adriansr added a commit to elastic/beats that referenced this pull request Feb 10, 2022
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana
that didn't include this change:

elastic/kibana#123894

After this change was merged, most visualisations in the dashboard
stopped working.

This doesn't affect older dashboards as those are migrated automatically
from an older version.

(cherry picked from commit a84c26e)

Co-authored-by: Adrian Serrano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
5 participants