-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix records field name and migrate #123894
[Lens] Fix records field name and migrate #123894
Conversation
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
…ternationalization
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally 👍
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana that didn't include this change: elastic/kibana#123894 After this change was merged, most visualisations in the dashboard stopped working. This doesn't affect older dashboards as those are migrated automatically from an older version.
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana that didn't include this change: elastic/kibana#123894 After this change was merged, most visualisations in the dashboard stopped working. This doesn't affect older dashboards as those are migrated automatically from an older version.
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana that didn't include this change: elastic/kibana#123894 After this change was merged, most visualisations in the dashboard stopped working. This doesn't affect older dashboards as those are migrated automatically from an older version. (cherry picked from commit a84c26e)
This dashboard had been exported from an 8.1.0-SNAPSHOT version of Kibana that didn't include this change: elastic/kibana#123894 After this change was merged, most visualisations in the dashboard stopped working. This doesn't affect older dashboards as those are migrated automatically from an older version. (cherry picked from commit a84c26e) Co-authored-by: Adrian Serrano <[email protected]>
Fixes #123824
This renames the name of the virtual "document" field to
___records___
- this shoudn't change the UI in any way as the display name stays i18n-ified. The weird name is chosen to make it unlikely to collide with actual user-supplied field names (Records
wasn't a great choice for that).To test manually:
i18n.locale: zn-CN
) - vis should still load