Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to set human readable title of data view & ability to edit data view #124191

Merged
merged 57 commits into from
Jun 8, 2022
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
fdd3365
ability to set human readable title of data view & ability to edit da…
shivindera Jan 31, 2022
1aaaccf
add readable data view title to discover
shivindera Jan 31, 2022
18daa04
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Feb 8, 2022
7f9a0fe
fix for failing API test
shivindera Feb 10, 2022
a348bd6
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Feb 22, 2022
56e3578
fix and add functional tests
shivindera Feb 22, 2022
5fb16a5
add missing lens support
shivindera Feb 22, 2022
cd7cf91
update snapshots after name change
shivindera Feb 22, 2022
2295bb0
fix for broken test and type checks
shivindera Feb 22, 2022
54ff3e0
fix condition check
shivindera Feb 23, 2022
2a162cc
Merge branch 'main' into edit-data-view
shivindera Mar 16, 2022
f602a2f
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Mar 16, 2022
f2edd41
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 3, 2022
b839a08
remove description, rename readableTitle to name and fixes
shivindera Apr 4, 2022
eb27e8c
revert kibana.yaml change
shivindera Apr 4, 2022
06208a1
fixes for failed tests
shivindera Apr 4, 2022
dc6f45c
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 11, 2022
a2c75b6
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 11, 2022
9221c42
fixes for broken tests
shivindera Apr 11, 2022
2445b13
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 12, 2022
2a4a6f8
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 17, 2022
9779565
fix functional tests 2
shivindera Apr 18, 2022
01348aa
add confirm modal for edit
shivindera Apr 18, 2022
2abd560
update header to match figma
shivindera Apr 18, 2022
505ff3f
fix data views with index pattern
shivindera Apr 18, 2022
878d18d
fix for badge breaking in test due to index change
shivindera Apr 18, 2022
acfc939
remove unused translations
shivindera Apr 18, 2022
ef4149a
comment fixes and add name to sample data
shivindera Apr 20, 2022
9199f00
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 20, 2022
6548c28
fix test for adding names to sample data
shivindera Apr 20, 2022
17dbe9b
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 20, 2022
0737f5a
some ui changes
shivindera Apr 20, 2022
8424691
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 20, 2022
b0909c6
fix for failing tests for removing Actions
shivindera Apr 20, 2022
4a288cf
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Apr 26, 2022
c13191e
comment fixes, change edit modal, fix breadcrumbs
shivindera Apr 26, 2022
b095590
change copy and fix for failing tests
shivindera May 2, 2022
a27da22
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera May 2, 2022
c857513
change text to have unique key
shivindera May 2, 2022
03f1b90
update jest snapshots
shivindera May 2, 2022
7e3cc93
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera May 2, 2022
1fd668c
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Jun 1, 2022
246c1a1
fixes for unified_search and some ui changes
shivindera Jun 1, 2022
1a3970a
add test fixes and disabled editing data view id when in edit mode
shivindera Jun 1, 2022
d69fa8b
fix for translation bug
shivindera Jun 1, 2022
832eef3
fix for failing tests
shivindera Jun 1, 2022
a749e34
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Jun 2, 2022
860277d
review comment changes
shivindera Jun 7, 2022
073dd23
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Jun 7, 2022
148b7f7
some nit fixes
shivindera Jun 7, 2022
9a9ca8d
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Jun 7, 2022
29f5779
revert the operation change check
shivindera Jun 7, 2022
ef7468c
fixed name not showing in dashboard with visualizations from differen…
shivindera Jun 7, 2022
309aaef
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Jun 7, 2022
3b1cb6d
added a comment for the management breadcrumb
shivindera Jun 8, 2022
9a353f5
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Jun 8, 2022
df92850
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera Jun 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into edit-data-view
shivindera committed Jun 2, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a749e34525a1c5ee1f2c4e441e1ecca3da242315
2 changes: 1 addition & 1 deletion src/plugins/data_views/common/data_views/data_views.ts
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ import { DuplicateDataViewError, DataViewInsufficientAccessError } from '../erro

const MAX_ATTEMPTS_TO_RESOLVE_CONFLICTS = 3;

export type IndexPatternSavedObjectAttrs = Pick<
export type DataViewSavedObjectAttrs = Pick<
DataViewAttributes,
'title' | 'type' | 'typeMeta' | 'name'
>;
You are viewing a condensed version of this merge commit. You can view the full changes here.