ability to set human readable title of data view & ability to edit data view

[shivindera]

Summary

• Ability to edit data view. Closes [Data views] Ability to edit data view #119175
• Ability to set human readable title of data view Ability to set human readable title of data view #117143

Images

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[mattkime]

• The breadcrumb buttons need to be updated to show name -

• And we need the same sort of 'confirm' modal thats used when runtime fields are renamed - when the index pattern or time field is changed

• The page title for data view details needs to be updated

• Apply data view detail header changes from figma mockups

• There's a 'data view' field in the current PR description screenshots - I think it should be 'index pattern'

[stratoula]

This is a great enhancement. I just have some comments/questions:

1. I can have data views with the same custom title, but when I am on the dataviews list, is a bit difficult to distinguish which of the 2 Ecommerce custom dataviews I want to edit/view.

2. We added the custom title in Lens but I think we should also add this to the rest visualizations: - Aggregation based visualizations:

Data view picker

Selected dataview

• TSVB

[mdefazio]

A few thoughts:

Edit Data view flyout

Shouldn't the index pattern be labeled as 'Index pattern' instead of Data view?

The footer button action should be 'Save' instead of 'Edit data view'

Manage data view

We should show both the title and index pattern here.

Actions dropdown:
Since we only have the two options (for now) and the add field button is still by the table, let's just make these two options exposed. Using the action menu was in conjuction with the other page edits

Updated:

Data view selection

I don't think we need the popover title here.
And I think we can rename the two options to:
Add field to this data view
Manage this data view
And change the search placeholder to
Find a data view
And the create button at the bottom to simply
New data view

Are we still wanting to provide a title by default (reusing the index pattern as an initial value). It seems this list will reference the title if available and fallback to the index pattern.
This might be confusing.

The concern is the following example where one is showing the title of a data view, while the others are showing the index pattern

---

Some of these edits get to question of how much we want to push data view titles at the onset. So perhaps I'm jumping ahead a bit, but it would seem we are treating these as simply optional descriptions at the moment rather than a title (which might be better anyway).

Either way, we should be consistent in how we're displaying these. If we just want these as optional descriptions, then let's just always show the index pattern in the dropdowns from Discover, Lens, etc. Then also keep the index pattern as h1 on the manage data view screen (with the optional title below it). But I'm a bit concerned swapping these depending on whether the title is filled out. We should always be referencing these as either the title or the index pattern in my opinion.

[mattkime]

I'm reviewing the mockups and making sure that everything in them makes it into a PR. I think it would be reasonable for this PR to include -

• the index pattern below the verbose title in the data view mgmt list

from #124346

[mdefazio]

I'm reviewing the mockups and making sure that everything in them makes it into a PR. I think it would be reasonable for this PR to include

@mattkime Thanks for double-checking. One question I had was whether we were always showing either the title or the index pattern in the dropdown for Discover, Lens, etc. I think we should be consistent so some aren't referencing the data view title and others the index pattern.
Also want to make sure we are including the index pattern + title on the data view detail page as well for the same reason as above.

[mattkime]

@mdefazio I think data view management is a special case. Showing the index patterns in the list form could be very helpful.

As for providing the index pattern in dropdowns - I guess I'd shy away from that. If users want the index pattern to be part of the name they can always make it part of the name.

[stratoula]

Yay! thanx for addressing my comments! LGTM!

[ppisljar]

lgtm

[kertal]

LGTM, tested I in the cloud, works as expected. This is a big step that will make data views like this to look more human than today 🥳

y

[cjcenizal]

Code LGTM, didn't test locally. Had one request for a code comment.

[TinaHeiligers]

LGTM

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: df92850
• Storybooks Preview
• Cloud Deployment
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dataViewEditor	97	99	+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2519	2521	+2
dataViews	184	186	+2
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
cases	352.3KB	352.4KB	+44.0B
controls	426.5KB	426.5KB	+4.0B
dataViewEditor	58.8KB	60.9KB	+2.0KB
dataViewFieldEditor	148.0KB	148.0KB	+4.0B
dataViewManagement	122.3KB	123.0KB	+643.0B
discover	447.8KB	447.8KB	+8.0B
lens	1.2MB	1.2MB	+68.0B
management	8.5KB	8.5KB	+17.0B
unifiedSearch	177.5KB	177.5KB	+4.0B
visDefaultEditor	142.4KB	142.4KB	+8.0B
visTypeTimeseries	466.3KB	466.3KB	+18.0B
visualizations	216.5KB	216.5KB	+4.0B
total			+2.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dataViewEditor	10.4KB	10.4KB	+22.0B
dataViews	38.3KB	38.5KB	+217.0B
management	9.7KB	9.7KB	+49.0B
savedObjects	28.9KB	29.0KB	+44.0B
unifiedSearch	44.0KB	44.0KB	+10.0B
total			+342.0B

Unknown metric groups

API count

id	before	after	diff
data	3369	3376	+7
dataViewEditor	14	15	+1
dataViews	914	924	+10
total			+18

ESLint disabled in files

id	before	after	diff
dataViewEditor	1	3	+2

ESLint disabled line counts

id	before	after	diff
dataViewEditor	2	4	+2

Total ESLint disabled count

id	before	after	diff
dataViewEditor	3	7	+4

History

• 💔 Build #49884 failed 9a353f5
• 💔 Build #49864 failed 3b1cb6d
• 💚 Build #49717 succeeded 309aaef
• 💚 Build #49703 succeeded 29f5779
• 💔 Build #49660 failed 9a9ca8d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream