Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Convert shared filenames and folders #122911

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

kpatticha
Copy link
Contributor

As part of #107347. I renamed the filenames and folders inside shared folders to follow snake_case convention.

move files from DatePicker TO date_picker
move files from EmptyMessage.tsx TO empty_message.tsx
move files from EnvironmentBadge TO environment_badge
move files from EnvironmentFilter TO environment_filter
move files from ErrorStatePrompt.tsx TO error_state_prompt.tsx
move files from HeightRetainer TO height_retainer
move files from ImpactBar TO impact_bar
move files from KeyValueTable TO key_value_table
move files from Links TO links
move files from LoadingStatePrompt.tsx TO loading_state_prompt.tsx
move files from MetadataTable TO metadata_table
move files from SelectWithPlaceholder TO select_with_placeholder
move files from Stacktrace TO stacktrace
move files from Summary TO summary
move files from TimestampTooltip TO timestamp_tooltip
move files from DiscoverLinks TO discover_links
move files from ElasticDocsLink.tsx TO elastic_docs_link.tsx
move files from InfraLink.test.tsx TO infra_link.test.tsx
move files from InfraLink.tsx TO infra_link.tsx
move files from MachineLearningLinks TO machine_learning_links
move files from SetupInstructionsLink.tsx TO setup_instructions_link.tsx
move files from CompositeSpanDurationSummaryItem.tsx TO composite_span_duration_summary_item.tsx
move files from DurationSummaryItem.tsx TO duration_summary_item.tsx
move files from HttpStatusBadge TO http_status_badge
move files from TransactionResultSummaryItem.tsx TO transaction_result_summary_item.tsx
move files from TransactionSummary.test.tsx TO transaction_summary.test.tsx
move files from TransactionSummary.tsx TO transaction_summary.tsx
move files from UserAgentSummaryItem.test.tsx TO user_agent_summary_item.test.tsx
move files from UserAgentSummaryItem.tsx TO user_agent_summary_item.tsx
move files from __fixtures__ TO _fixtures__
move files from APMLink.test.tsx TO apmlink.test.tsx
move files from APMLink.tsx TO apmlink.tsx
move files from ErrorDetailLink.tsx TO error_detail_link.tsx
move files from ErrorOverviewLink.tsx TO error_overview_link.tsx
move files from HomeLink.tsx TO home_link.tsx
move files from MetricOverviewLink.tsx TO metric_overview_link.tsx
move files from ServiceMapLink.tsx TO service_map_link.tsx
move files from ServiceNodeMetricOverviewLink.tsx TO service_node_metric_overview_link.tsx
move files from ServiceNodeOverviewLink.tsx TO service_node_overview_link.tsx
move files from TraceOverviewLink.tsx TO trace_overview_link.tsx
move files from agentConfigurationLinks.tsx TO agent_configuration_links.tsx
move files from DiscoverErrorButton.test.tsx TO discover_error_button.test.tsx
move files from DiscoverErrorLink.test.tsx TO discover_error_link.test.tsx
move files from DiscoverErrorLink.tsx TO discover_error_link.tsx
move files from DiscoverLink.tsx TO discover_link.tsx
move files from DiscoverLinks.integration.test.tsx TO discover_links.integration.test.tsx
move files from DiscoverSpanLink.tsx TO discover_span_link.tsx
move files from DiscoverTransactionLink.test.tsx TO discover_transaction_link.test.tsx
move files from DiscoverTransactionLink.tsx TO discover_transaction_link.tsx
move files from MLExplorerLink.test.tsx TO mlexplorer_link.test.tsx
move files from MLExplorerLink.tsx TO mlexplorer_link.tsx
move files from MLManageJobsLink.test.tsx TO mlmanage_jobs_link.test.tsx
move files from MLManageJobsLink.tsx TO mlmanage_jobs_link.tsx
move files from MLSingleMetricLink.test.tsx TO mlsingle_metric_link.test.tsx
move files from MLSingleMetricLink.tsx TO mlsingle_metric_link.tsx
move files from LastTickValue.tsx TO last_tick_value.tsx
move files from Marker TO marker
move files from Timeline.test.tsx TO timeline.test.tsx
move files from VerticalLines.tsx TO vertical_lines.tsx
move files from plotUtils.ts TO plot_utils.ts
move files from FormattedValue.tsx TO formatted_value.tsx
move files from KeyValueTable.test.tsx TO key_value_table.test.tsx
move files from ErrorMetadata TO error_metadata
move files from MetadataTable.test.tsx TO metadata_table.test.tsx
move files from Section.test.tsx TO section.test.tsx
move files from Section.tsx TO section.tsx
move files from SpanMetadata TO span_metadata
move files from TransactionMetadata TO transaction_metadata
move files from HttpStatusBadge.test.tsx TO http_status_badge.test.tsx
move files from statusCodes.ts TO status_codes.ts

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Jan 13, 2022
@kpatticha kpatticha requested review from a team as code owners January 13, 2022 09:12
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing it 🐍

@kpatticha
Copy link
Contributor Author

@elasticmachine merge upstream

@kpatticha kpatticha enabled auto-merge (squash) January 14, 2022 06:46
@kpatticha kpatticha force-pushed the convert-shared-folder branch from 7ed4f5f to 9713ced Compare January 14, 2022 06:50
@kpatticha kpatticha disabled auto-merge January 14, 2022 06:52
@kpatticha kpatticha force-pushed the convert-shared-folder branch from 1cac623 to 38b6048 Compare January 14, 2022 07:25
@kpatticha kpatticha force-pushed the convert-shared-folder branch from f541126 to 15a7ddf Compare January 14, 2022 09:15
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U X changes LGTM !!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +2.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 46196f2 into elastic:main Jan 14, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants