-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Convert camelCase to snake_case for all files and folders #107347
Comments
Pinging @elastic/apm-ui (Team:apm) |
Please assign it to me, I'll do it. Also, tell me which files and folders you want me to include. |
@mohitsaxenaknoldus if you delete these lines: https://github.com/smith/kibana/blob/7216bab3521bd395a019ef8af3392d25f0f912a6/src/dev/precommit_hook/casing_check_config.js#L60-L64 Then run If you're on a platform with a case-insensitive filesystem (macOS by default), you'll need to have
in .git/config. If you're just changing the casing of a filename (from upper to lowercase) you may need to use I've tried doing this with some automated tools, but there might be a lot of work that has to be done manually. If you're doing this work you'll want to be fetching from upstream (elastic/kibana) and merging from upstream frequently as code is changing quite often in Kibana and this kind of change can have a lot of conflicts if not kept up to date. Please let me know if you have any problems or questions. |
Thanks @smith! I've added your comment to the issue description. |
When I do:
|
@mohitsaxenaknoldus you probably need to run |
I'm working on renaming all the files in |
Kibana is using snake_case for all files and folders but APM has a mixed filenaming scheme. APM should use snake_case like the rest of Kibana.
APM has disabled Kibana's filename check. This check should be re-enabled again.
Steps
Remove/uncomment the following lines to re-add case-checking of APM files:
kibana/src/dev/precommit_hook/casing_check_config.js
Lines 60 to 64 in 9d42d67
Run
node scripts/check_file_casing.js
from kibana rootFix all the filename errors listed in the step above
Run
node scripts/check_file_casing.js
again to verify all errors are fixedNotes
If you're on a platform with a case-insensitive filesystem (macOS by default), you'll need to have
in .git/config.
If you're just changing the casing of a filename (from upper to lowercase) you may need to use
git mv -f
to rename the files and make sure github notices.Tasks
x-pack/plugins/apm/public/**/*
x-pack/plugins/apm/scripts/**/*
The text was updated successfully, but these errors were encountered: