Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fixes metrics test flakiness by using the Lens waitForVisualization function #122532

Merged
merged 2 commits into from
Jan 11, 2022
Merged

[Lens] Fixes metrics test flakiness by using the Lens waitForVisualization function #122532

merged 2 commits into from
Jan 11, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 10, 2022 •
edited
Loading

Fixes #122489

From the CI screenshot we can see that the color has been updated correctly. This must be a race-condition. By waiting for the actual visualization to load first and then get the metricStyle, must fix this flakiness.

image

CI run 50 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/73#cd10b996-e954-4b94-b8fc-c04b2739f205
Ci run 50 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/75#b0d5a525-b06a-41c8-bbc7-66dad484f24f

Checklist

@stratoula stratoula changed the title [Lens] Fixes metrics test flakiness by using the Lens waitForVisualiz… [Lens] Fixes metrics test flakiness by using the Lens waitForVisualization function Jan 10, 2022
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v7.17.0 v8.0.0 v8.1.0 Feature:Lens labels Jan 10, 2022
flash1293
flash1293 reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change line 47 and 54 in this file as well? It has the potential for the same issue

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review January 11, 2022 06:30
@stratoula stratoula requested a review from a team as a code owner January 11, 2022 06:30
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@stratoula stratoula added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 11, 2022
@stratoula stratoula merged commit d1049ca into elastic:main Jan 11, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.0:
- [8.0] [UA] - Add warning to accept for reindex (#122249)
- Cleaning up after DLS functional tests. (#122426)
- Add URLs from ui_settings.ts to doc link service (#122408)
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Cleaning up after DLS functional tests. (#122426)

How to fix

Re-run the backport manually:

node scripts/backport --pr 122532

Questions ?

Please refer to the Backport tool documentation

@dej611
Copy link
Contributor

dej611 commented Jan 11, 2022

Dynamic coloring for metrics is only available for 8.1+ . So probably this should not be backported?

@stratoula
Copy link
Contributor Author

I always forget that :D

@stratoula stratoula removed v8.0.0 v7.17.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 11, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122532 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
6 participants
@stratoula @kibana-ci @elasticmachine @kibanamachine @dej611 @flash1293