Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/metrics·ts - lens app lens metrics should change the color of the metric when tweaking the values in the panel #122489

Closed
kibanamachine opened this issue Jan 7, 2022 · 3 comments · Fixed by #122532
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 7, 2022

A test failed on a tracked branch

Error: expected 'rgb(214, 191, 87)' to equal 'rgb(32, 146, 128)'
    at Assertion.assert (/opt/local-ssd/buildkite/builds/kb-n2-4-800fe8e29f1738a9/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/opt/local-ssd/buildkite/builds/kb-n2-4-800fe8e29f1738a9/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:227:8)
    at Assertion.be (/opt/local-ssd/buildkite/builds/kb-n2-4-800fe8e29f1738a9/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:69:22)
    at Context.<anonymous> (test/functional/apps/lens/metrics.ts:42:33)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/opt/local-ssd/buildkite/builds/kb-n2-4-800fe8e29f1738a9/elastic/kibana-hourly/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 7, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 7, 2022
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@dej611 dej611 added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 10, 2022
@flash1293
Copy link
Contributor

From the screenshot you can see the color actually changed - this is likely a race-condition. The test uses waitUntilLoadingHasFinished which is just checking the loading spinner, not whether the vis updated:

await PageObjects.header.waitUntilLoadingHasFinished();

Using waitForVisualization from the Lens page should fix this (it's more robust by waiting for rendering to settle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants