Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix security solution network page #122447

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 6, 2022

Fixes regression caused by #118617

#118617 renamed some constants in Maps. Security solution has using hard coded strings instead of the constants so there were no typescript errors flagging the now wrong values. This PR updates the strings to use constants from maps.

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Jan 6, 2022
@nreese nreese requested a review from a team as a code owner January 6, 2022 16:49
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo on the file path. Thank you!

@nreese
Copy link
Contributor Author

nreese commented Jan 10, 2022

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Jan 10, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +76.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 0619acb into elastic:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants