Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] rename layer types provide more distinguishable names that better reflect layer #118617

Merged
merged 16 commits into from
Dec 3, 2021
Merged

[maps] rename layer types provide more distinguishable names that better reflect layer #118617

merged 16 commits into from
Dec 3, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 15, 2021 •
edited
Loading

  • Rename TileLayer to RasterTileLayer
  • Rename VectorTileLayer to EmsVectorTileLayer
  • Updates EmsVectorTileLayer to extend from AbstractLayer instead of RasterTileLayer
  • LAYER.TYPE updates
    • TILED_VECTOR replaced with MVT_VECTOR
    • VECTOR_TILE replaced with EMS_VECTOR_TILE
    • VECTOR replaced with GEOJSON_VECTOR
    • TILE replaced with RASTER_TILE
  • Add migration scripts for LAYER_TYPE changes

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Nov 15, 2021
nreese
nreese commented Nov 16, 2021
View reviewed changes
x-pack/plugins/maps/public/classes/layers/ems_vector_tile_layer/ems_vector_tile_layer.tsx Outdated
@@ -241,10 +264,11 @@ export class VectorTileLayer extends TileLayer {
}
const newLayerObject = {
...layer,
source:
source: this._generateMbSourceId(
Copy link
Contributor Author

@nreese nreese Nov 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes layer re-ordering regression caused by #117745

Original code was source: this._generateMbSourceId(layer.source),. This fix keeps the original code's behavior of always setting source to _generateMbSourceId.

thomasneirynck
thomasneirynck approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green CI

discussed offline. This changes the values on the saved-objects as well. Agreed that this will aid in readability going forward (post 8.1), at the expense of widening scope of this PR.

@nreese nreese marked this pull request as ready for review November 16, 2021 23:22
@nreese nreese requested review from a team as code owners November 16, 2021 23:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Nov 17, 2021

@elasticmachine merge upstream

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@nreese nreese mentioned this pull request Nov 17, 2021
Closed
shahzad31
shahzad31 approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

@nreese
Copy link
Contributor Author

nreese commented Dec 3, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 3, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +16.0B
dataVisualizer 538.1KB 538.1KB +8.0B
maps 2.6MB 2.6MB +398.0B
ml 3.5MB 3.5MB +8.0B
total +430.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 38.6KB 38.6KB +42.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 72765c9 into elastic:main Dec 3, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@nreese @kibanamachine @TinLe
[maps] rename layer types provide more distinguishable names that bet…
58d2e50 
…ter reflect layer (elastic#118617)

* [maps] rename layer types provide more distinguishable names that better refect layer

* fix migration rename

* revert extends change for EmsVectorTileLayer

* tsling

* fix regression and jest test

* extend from Abstract instead of RasterTile

* better fix

* fix tests

* more test fixes

* update path for newly merged code

Co-authored-by: Kibana Machine <[email protected]>
@nreese nreese mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nreese @elasticmachine @kibana-ci @thomasneirynck @shahzad31 @kibanamachine