Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Stop passing ES the a deprecated ignore_throttled=true params #120671

Merged
merged 1 commit into from
Dec 8, 2021
Merged

[Reporting] Stop passing ES the a deprecated ignore_throttled=true params #120671

merged 1 commit into from
Dec 8, 2021

Conversation

tsullivan
Copy link
Member

Summary

Reporting part for #117980

@tsullivan tsullivan requested review from a team as code owners December 7, 2021 20:04
@tsullivan tsullivan added v7.16.0 v7.17.0 v8.0.0 v8.1.0 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx labels Dec 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@tsullivan tsullivan changed the title [Reporting] do not pass a deprecated param by default [Reporting] Stop passing ES the a deprecated ignore_throttled=true params Dec 7, 2021
@tsullivan tsullivan mentioned this pull request Dec 7, 2021
Closed
5 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger added v7.16.1 and removed v7.16.0 labels Dec 7, 2021
jloleysens
jloleysens approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this addresses the issue of removing the deprecation log. This change gives users control of over whether this deprecation is shown by linking it the "Search in frozen indices" advanced setting.

@tsullivan tsullivan merged commit 1b65b1a into elastic:main Dec 8, 2021
@tsullivan tsullivan mentioned this pull request Dec 8, 2021
Merged
tsullivan added a commit to tsullivan/kibana that referenced this pull request Dec 8, 2021
@tsullivan
[Reporting] do not pass a deprecated param by default (elastic#120671)
b052703
tsullivan added a commit to tsullivan/kibana that referenced this pull request Dec 8, 2021
@tsullivan
[Reporting] do not pass a deprecated param by default (elastic#120671)
19b43d2
@tsullivan tsullivan mentioned this pull request Dec 8, 2021
Merged
tsullivan added a commit that referenced this pull request Dec 8, 2021
@tsullivan
[Reporting] do not pass a deprecated param by default (#120671) (#120847
1038c03 
)
tsullivan added a commit that referenced this pull request Dec 8, 2021
@tsullivan
[Reporting] do not pass a deprecated param by default (#120671) (#120848
b425b06 
)
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@tsullivan @TinLe
[Reporting] do not pass a deprecated param by default (elastic#120671)
122eb42
@tsullivan tsullivan deleted the reporting/suppress-ignore_throttled_param-warning branch December 27, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.16.1 v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsullivan @elasticmachine @kibana-ci @jloleysens @spalger