Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.16] Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning #117980

Closed
5 tasks done
rudolf opened this issue Nov 9, 2021 · 6 comments
Closed
5 tasks done

[7.16] Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning #117980

rudolf opened this issue Nov 9, 2021 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:CSV Reporting issues pertaining to CSV file export impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v7.16.0 v7.17.0

Comments

@rudolf
Copy link
Contributor

rudolf commented Nov 9, 2021 •
edited
Loading

ignore_throttled and frozen indices have been deprecated in 7.16 elastic/elasticsearch#77864

As a result, sending ignore_throttled=true or ignore_throttled=false both generates deprecation warnings.

To avoid noisy deprecation warnings over which the user has no control, Kibana should only include this parameter if searching over frozen indices (e.g. ignore_throttled=false because the Advanced Setting search:includeFrozen: true), i.e. you should NOT send ignore_throttled: true in the request, which is anyway the default behavior.

Related #112621 #120043
@rudolf rudolf added bug Fixes for quality problems that affect the customer experience v7.16.0 labels Nov 9, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 9, 2021
@rudolf rudolf added Team:APM All issues that need APM UI Team support Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Reporting Services Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 9, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@sorenlouv
Copy link
Member

sorenlouv commented Nov 9, 2021 •
edited
Loading

Since it'll no longer be possible to search frozen indices without seeing a deprecation warning, is the recommendation going forward for users to unfreeze frozen indices and thus not relying on ignore_throttled?

Btw I created an issue to track this on the APM board: #117991

@sorenlouv sorenlouv mentioned this issue Nov 9, 2021
Closed
2 tasks
@rudolf
Copy link
Contributor Author

rudolf commented Nov 9, 2021

@sqren The deprecation message from ES recommends switch to cold or frozen tiers:

...frozen indices have been deprecated. Consider cold or frozen tiers in place of frozen indices.

alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 9, 2021
@alexwizp
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
361a628 
…ndices to avoid deprecation warning

Part of: elastic#117980
@alexwizp alexwizp mentioned this issue Nov 9, 2021
Merged
alexwizp added a commit that referenced this issue Nov 10, 2021
@alexwizp
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
9433346 
…ndices to avoid deprecation warning (#118022)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: #117980

* add tests
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 10, 2021
@alexwizp @kibanamachine
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
3fe4526 
…ndices to avoid deprecation warning (elastic#118022)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: elastic#117980

* add tests
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 10, 2021
@alexwizp @kibanamachine
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
809a905 
…ndices to avoid deprecation warning (elastic#118022)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: elastic#117980

* add tests
@timroes timroes mentioned this issue Nov 10, 2021
Merged
kibanamachine added a commit that referenced this issue Nov 10, 2021
@kibanamachine @alexwizp
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
f82874d 
…ndices to avoid deprecation warning (#118022) (#118173)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: #117980

* add tests

Co-authored-by: Alexey Antonov <[email protected]>
@dannycroft dannycroft added [zube]: Inbox and removed Team:APM All issues that need APM UI Team support [zube]: Inbox labels Nov 10, 2021
kibanamachine added a commit that referenced this issue Nov 10, 2021
@kibanamachine @alexwizp
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
7e58210 
…ndices to avoid deprecation warning (#118022) (#118172)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: #117980

* add tests

Co-authored-by: Alexey Antonov <[email protected]>
@MiriamAparicio MiriamAparicio mentioned this issue Nov 11, 2021
Merged
@flash1293 flash1293 removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 12, 2021
@rudolf rudolf added the v7.17.0 label Dec 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@tsullivan tsullivan mentioned this issue Dec 7, 2021
Merged
@tsullivan
Copy link
Member

PR to clean up the Reporting area: #120671

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Dec 7, 2021
@tsullivan
Copy link
Member

@rudolf the Reporting PR has been merged and backported. This issue looks ready to close

@rudolf rudolf closed this as completed Dec 9, 2021
@sophiec20 sophiec20 added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:CSV Reporting issues pertaining to CSV file export and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:CSV Reporting issues pertaining to CSV file export impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v7.16.0 v7.17.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@dannycroft @sorenlouv @tsullivan @rudolf @flash1293 @sophiec20 @elasticmachine @vadimkibana