Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Host isolation exceptions by policy, add missing validation when no policy is selected #120500

Merged
merged 3 commits into from
Dec 6, 2021
Merged

[Security Solution] Host isolation exceptions by policy, add missing validation when no policy is selected #120500

merged 3 commits into from
Dec 6, 2021

Conversation

academo
Copy link
Contributor

@academo academo commented Dec 6, 2021 •
edited
Loading

Summary

Fixes an issue introduced with #119828 when the switch between global and per-policy won't work on specific cases:

  • When the exception is per-policy without policies
  • When a non-policy tag is present.

Checklist

Delete any items that are not applicable to this PR.

@academo academo added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0 labels Dec 6, 2021
@academo academo requested a review from a team as a code owner December 6, 2021 15:09
@academo academo requested review from pzl and dasansol92 December 6, 2021 15:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@academo academo requested review from ashokaditya and paul-tavares and removed request for dasansol92 December 6, 2021 15:09
ashokaditya
ashokaditya approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🐑

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #6 / security APIs - Audit Log Audit Log logs audit events when reading and writing saved objects

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -14.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@academo academo merged commit 9a8d888 into elastic:main Dec 6, 2021
@academo academo deleted the fix/host-isolation-exceptions-by-policy-merge-fix branch December 6, 2021 18:45
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 6, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@academo @TinLe
[Security Solution] Host isolation exceptions by policy, add missing …
8ce8f42 
…validation when no policy is selected (elastic#120500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

@pzl pzl Awaiting requested review from pzl pzl was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

@paul-tavares paul-tavares Awaiting requested review from paul-tavares

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@academo @elasticmachine @kibana-ci @ashokaditya @kevinlog @kibanamachine