[Security Solution] Host isolation exceptions by policy, add missing …

…validation when no policy is selected (#120500)
elastic · Dec 6, 2021 · 9a8d888 · 9a8d888
1 parent f2ef652
commit 9a8d888
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/...ck/plugins/security_solution/public/management/components/effected_policy_select/utils.ts b/...ck/plugins/security_solution/public/management/components/effected_policy_select/utils.ts
@@ -47,7 +47,7 @@ export function getEffectedPolicySelectionByTags(
   tags: string[],
   policies: PolicyData[]
 ): EffectedPolicySelection {
-  if (tags.length === 0 || tags.find((tag) => tag === GLOBAL_POLICY_TAG)) {
+  if (tags.find((tag) => tag === GLOBAL_POLICY_TAG)) {
     return {
       isGlobal: true,
       selected: [],

diff --git a/..._solution/public/management/pages/host_isolation_exceptions/view/components/form.test.tsx b/..._solution/public/management/pages/host_isolation_exceptions/view/components/form.test.tsx
@@ -233,5 +233,21 @@ describe('When on the host isolation exceptions entry form', () => {
         'true'
       );
     });
+
+    it('should show the policies selector when no policy is selected', () => {
+      existingException.tags = [];
+
+      renderResult = render(existingException);
+
+      expect(renderResult.queryByTestId('effectedPolicies-select-policiesSelectable')).toBeTruthy();
+    });
+
+    it('should show the policies selector when no policy is selected and there are previous tags', () => {
+      existingException.tags = ['non-a-policy-tag'];
+
+      renderResult = render(existingException);
+
+      expect(renderResult.queryByTestId('effectedPolicies-select-policiesSelectable')).toBeTruthy();
+    });
   });
 });