Fix CLI formatting on windows #119435
Merged
Fix CLI formatting on windows #119435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomheymann
added
v8.0.0
release_note:skip
|
ACK: reviewing... |
azasypkin
approved these changes
Nov 23, 2021
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| export function formatBashCommand(command: string, args?: string) { |
There was a problem hiding this comment.
optional nit: It's not a big deal at all, just wanted to note: it sounds like too much credit to Bash shell here ;) Maybe something like formatCommadLineSnippet\formatCli... would be more OS/shell agnostic.
|
|
||
| export function formatBashCommand(command: string, args?: string) { | ||
| const isWindows = window.navigator.userAgent.includes('Win'); | ||
| return `${isWindows ? `bin\\${command}.bat` : `bin/${command}`}${args ? ` ${args}` : ''}`; |
There was a problem hiding this comment.
note: it's great that we have this code in one place now 🎉 If users ever complain about false positives here we'll need to update just one place (e.g. fetch actual OS from the server).
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2021
* Provide more guidance on enrollment token * Added suggestions from copy review * Simplify copy * format bash commands correctly * Added suggestions from code review
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 23, 2021
* Provide more guidance on enrollment token * Added suggestions from copy review * Simplify copy * format bash commands correctly * Added suggestions from code review Co-authored-by: Thom Heymann <[email protected]>
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Provide more guidance on enrollment token * Added suggestions from copy review * Simplify copy * format bash commands correctly * Added suggestions from code review
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* Provide more guidance on enrollment token * Added suggestions from copy review * Simplify copy * format bash commands correctly * Added suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CLI command formatting on windows
.