Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service maps error after clicking on multiple services #119077

Merged
merged 1 commit into from
Nov 19, 2021
Merged

[APM] Service maps error after clicking on multiple services #119077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions x-pack/plugins/apm/public/components/app/service_map/Popover/backend_contents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,14 @@ export function BackendContents({
);

const isLoading = status === FETCH_STATUS.LOADING;
const detailsUrl = apmRouter.link('/backends/overview', {
query: {
...query,
backendName,
} as TypeOf<ApmRoutes, '/backends/overview'>['query'],
});
const detailsUrl = backendName
? apmRouter.link('/backends/overview', {
query: {
...query,
backendName,
} as TypeOf<ApmRoutes, '/backends/overview'>['query'],
})
: undefined;
Comment on lines +60 to +67
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't this fail before? Is backendName optional when it should be required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend is required for the /backends/overview route, but not all nodes on service maps have it, so the problem was that it was trying to generate the URL with an undefined value.


const trackEvent = useUiTracker();

Expand Down