[APM] Service maps error after clicking on multiple services #119077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
cauemarcondes
added
release_note:fix
and removed
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
sorenlouv
reviewed
Nov 19, 2021
Comment on lines
+60
to
+67
| const detailsUrl = backendName | ||
| ? apmRouter.link('/backends/overview', { | ||
| query: { | ||
| ...query, | ||
| backendName, | ||
| } as TypeOf<ApmRoutes, '/backends/overview'>['query'], | ||
| }) | ||
| : undefined; |
There was a problem hiding this comment.
Why didn't this fail before? Is backendName optional when it should be required?
There was a problem hiding this comment.
backend is required for the /backends/overview route, but not all nodes on service maps have it, so the problem was that it was trying to generate the URL with an undefined value.
sorenlouv
approved these changes
Nov 19, 2021
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2021
#119169) Co-authored-by: Cauê Marcondes <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2021
#119170) Co-authored-by: Cauê Marcondes <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
|
tests ok |
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #118884
service.maps.mov