Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] fix alignment #117378

Merged
merged 2 commits into from
Nov 4, 2021
Merged

[Lens] fix alignment #117378

merged 2 commits into from
Nov 4, 2021

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Nov 3, 2021 •
edited by nickofthyme
Loading

Summary

Fixes alignment between warning sign and "Experimental" badge:

Screen Shot 2021-11-03 at 11 19 39 AM

Fix #116443.

@cla-checker-service
Copy link

cla-checker-service bot commented Nov 3, 2021 •
edited
Loading

💚 CLA has been signed

@drewdaemon drewdaemon force-pushed the 116443/experimental-flag-style-fix branch from ff80b1a to 4fc617e Compare November 3, 2021 16:46
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@drewdaemon drewdaemon added v8.1.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 3, 2021
@drewdaemon drewdaemon changed the title fix alignment [Lens] fix alignment Nov 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 955.8KB 955.8KB +20.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon marked this pull request as ready for review November 4, 2021 00:17
@drewdaemon drewdaemon requested a review from a team as a code owner November 4, 2021 00:17
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@mbondyra
Copy link
Contributor

mbondyra commented Nov 4, 2021

Tested in Safari, FF and CHrome and aligns nicely in all of them. Approved!

@drewdaemon drewdaemon merged commit 37571a4 into elastic:main Nov 4, 2021
@drewdaemon drewdaemon deleted the 116443/experimental-flag-style-fix branch November 4, 2021 14:52
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117378 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117378 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117378 or prevent reminders by adding the backport:skip label.

@flash1293 flash1293 added the backport:skip This commit does not require backporting label Nov 11, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Experimental flag + warning sign are not correctly aligned
5 participants
@drewdaemon @kibanamachine @elasticmachine @mbondyra @flash1293