Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Experimental flag + warning sign are not correctly aligned #116443

Closed
dej611 opened this issue Oct 27, 2021 · 3 comments · Fixed by #117378
Closed

[Lens] Experimental flag + warning sign are not correctly aligned #116443

dej611 opened this issue Oct 27, 2021 · 3 comments · Fixed by #117378
Assignees
@flash1293
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Oct 27, 2021

Describe the bug:

The Warning sign and Experimental badge for the Heatmap are not well aligned together.

Depending on the speed of #102036 may be worth to address this small issue.

Steps to reproduce:

  1. Create any XY chart with a reference layer
  2. Open the chart selector dropdown and scroll down to the Heatmap

Chrome:
Screenshot 2021-10-27 at 15 35 07

Safari:
Screenshot 2021-10-27 at 15 32 47

Edge on Mac:
Screenshot 2021-10-27 at 15 34 20
@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@flash1293
Copy link
Contributor

Putting alignItems="center" on the surrounding EuiFlexGroup fixes this problem:

kibana/x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/chart_switch.tsx

Line 371 in 6bfa2a4

className="lnsChartSwitch__append"

@flash1293 flash1293 added the good first issue low hanging fruit label Oct 27, 2021
@flash1293
Copy link
Contributor

Please do not start working on this, reserving this issue.

@flash1293 flash1293 self-assigned this Oct 27, 2021
@drewdaemon drewdaemon mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flash1293 flash1293

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] fix alignment drewdaemon/kibana
3 participants
@dej611 @flash1293 @elasticmachine