[Fleet] Delete non existing streams in overrideInputs #116998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
reviewed
Nov 1, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kpollich
approved these changes
Nov 1, 2021
| @@ -1111,7 +1112,9 @@ export function overridePackageInputs( | |||
| } | |||
|
|
|||
| if (override.vars) { | |||
| originalInput = deepMergeVars(originalInput, override) as NewPackagePolicyInput; | |||
| const indexOfInput = inputs.indexOf(originalInput); | |||
There was a problem hiding this comment.
Ahh I see the issue. Nasty bug - thank you for tracking it down. We were mutating this object but never actually replacing it in the original array. Good catch!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 2, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 2, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2021
) Co-authored-by: Nicolas Chaulet <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2021
) Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #116985
When you try to upgrade from 7.12 to 7.16 you get that error
That error is here because we do not delete datastreams that do not exists anymore in the auto upgrade feature, that PR should change that.