Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] auto upgrade pacakge policies do not handle correctly stream deletion #116985

Closed
nchaulet opened this issue Nov 1, 2021 · 7 comments · Fixed by #116998 or #117594
Closed

[Fleet] auto upgrade pacakge policies do not handle correctly stream deletion #116985

nchaulet opened this issue Nov 1, 2021 · 7 comments · Fixed by #116998 or #117594
Assignees
@nchaulet
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0

Comments

@nchaulet
Copy link
Member

nchaulet commented Nov 1, 2021

Description

The autoupgrade feature do not handle correctly when a stream is deleted. You can try upgrading from Kibana 7.12 to 7.16 and the system package throw this

Screen Shot 2021-10-29 at 11 56 51 AM
@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 labels Nov 1, 2021
@nchaulet nchaulet self-assigned this Nov 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover
Copy link
Contributor

This feels like a release blocker to me cc @jen-huang @ruflin

@ruflin
Copy link
Contributor

ruflin commented Nov 2, 2021

Do we already know why it is happening? Is there a workaround? Does it "only" affect Fleet or are more parts of Kibana affected? Is it also upgrade from 7.12 to 7.16 or also 7.15 to 7.16? But yes, sounds bad.

@kpollich kpollich mentioned this issue Nov 2, 2021
Merged
@nchaulet
Copy link
Member Author

nchaulet commented Nov 4, 2021

Just tested with the latest SNAPSHOT and looks like the issue is still here.

@nchaulet nchaulet reopened this Nov 4, 2021
@nchaulet
Copy link
Member Author

nchaulet commented Nov 4, 2021 •
edited
Loading

@ruflin The issue seems to be related to the fact we now auto upgrade the system package policies and a data stream as been removed since 7.12. It only affect Fleet from 7.12 to 7.16 not 7.15 to 7.16

kpollich added a commit to kpollich/kibana that referenced this issue Nov 4, 2021
@kpollich
Consider all errors non-fatal during dry runs
463c6f4 
Since we've enabled auto upgrades for some packages in 7.16, we need to
revert a previous change that only considered policy validation errors
non-fatal. Any error encountered during the dry-run/upgrade process
should be considered non-fatal so that users can still access the Fleet
UI if setup fails.

Fixes elastic#116985
@kpollich kpollich mentioned this issue Nov 4, 2021
Merged
@joshdover
Copy link
Contributor

7.12 to 7.16 not 7.15 to 7.16

Ok if it doesn't affect 7.14 GA -> 7.16 then I don't think it should be a release blocker but we'll likely get a fix in before release anyways.

kpollich added a commit that referenced this issue Nov 5, 2021
@kpollich
Consider all errors non-fatal during dry runs (#117594)
b7076e8 
Since we've enabled auto upgrades for some packages in 7.16, we need to
revert a previous change that only considered policy validation errors
non-fatal. Any error encountered during the dry-run/upgrade process
should be considered non-fatal so that users can still access the Fleet
UI if setup fails.

Fixes #116985
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 5, 2021
@kpollich @kibanamachine
Consider all errors non-fatal during dry runs (elastic#117594)
5d9891f 
Since we've enabled auto upgrades for some packages in 7.16, we need to
revert a previous change that only considered policy validation errors
non-fatal. Any error encountered during the dry-run/upgrade process
should be considered non-fatal so that users can still access the Fleet
UI if setup fails.

Fixes elastic#116985
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 5, 2021
@kpollich @kibanamachine
Consider all errors non-fatal during dry runs (elastic#117594)
e06abcf 
Since we've enabled auto upgrades for some packages in 7.16, we need to
revert a previous change that only considered policy validation errors
non-fatal. Any error encountered during the dry-run/upgrade process
should be considered non-fatal so that users can still access the Fleet
UI if setup fails.

Fixes elastic#116985
kibanamachine added a commit that referenced this issue Nov 5, 2021
@kibanamachine @kpollich
Consider all errors non-fatal during dry runs (#117594) (#117704)
32f7706 
Since we've enabled auto upgrades for some packages in 7.16, we need to
revert a previous change that only considered policy validation errors
non-fatal. Any error encountered during the dry-run/upgrade process
should be considered non-fatal so that users can still access the Fleet
UI if setup fails.

Fixes #116985

Co-authored-by: Kyle Pollich <[email protected]>
kibanamachine added a commit that referenced this issue Nov 5, 2021
@kibanamachine @kpollich
Consider all errors non-fatal during dry runs (#117594) (#117705)
a19b031 
Since we've enabled auto upgrades for some packages in 7.16, we need to
revert a previous change that only considered policy validation errors
non-fatal. Any error encountered during the dry-run/upgrade process
should be considered non-fatal so that users can still access the Fleet
UI if setup fails.

Fixes #116985

Co-authored-by: Kyle Pollich <[email protected]>
@ruflin
Copy link
Contributor

ruflin commented Nov 9, 2021

Above @nchaulet mentions 7.15 to 7.16. Does it also work 7.14 to 7.16 which @joshdover posted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nchaulet nchaulet

Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@ruflin @nchaulet @joshdover @elasticmachine