Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to EUI v40.1.0 #116692

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Upgrade to EUI v40.1.0 #116692

merged 6 commits into from
Nov 1, 2021

Conversation

cee-chen
Copy link
Contributor

Summary

[email protected] ⏩ [email protected]

40.1.0

  • Added styling support for valign prop on EuiTableRowCell (#5283)
  • Added remark-breaks plugin to mimic GitHub-flavored markdown line breaks within EuiMarkdownEditor (#5272)
  • Removed EuiErrorBoundary from EuiDatePicker when unsupported props are used (#5318)

Bug fixes

  • Fixed default text alignment in EuiTableRowCell on Safari (#5283)
  • Fixed mobileOptions.truncateText from getting overridden by truncateText in EuiTableRowCell (#5283)
  • Fixed issue with dynamic row counts in EuiDataGrid (#5313)
  • Fixed EuiDataGrid to dynamically update row heights when set to auto (#5281)

Theme: Amsterdam

  • Fixed mobileOptions.enlarge styling in EuiTableRowCell (#5283)
  • Fixed EuiDataGrid's expanded density not increasing font size on Amsterdam (#5320)

@cee-chen cee-chen added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Oct 28, 2021
@cee-chen cee-chen requested a review from VladLasitsa October 28, 2021 17:22
VladLasitsa
VladLasitsa approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cee-chen
Copy link
Contributor Author

@elasticmachine merge upstream

@brianseeders brianseeders changed the base branch from main to master October 29, 2021 15:17
@cee-chen cee-chen marked this pull request as ready for review October 29, 2021 18:32
@cee-chen cee-chen requested review from a team as code owners October 29, 2021 18:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

spalger
spalger approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operations LGTM

matschaffer
matschaffer approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine popperPlacement being anything but a typo, so LGTM for infra UI team :)

Update: ah, I see the deprecation note now. Nice. Thanks for the clean up.

@cee-chen
Copy link
Contributor Author

cee-chen commented Nov 1, 2021

@elasticmachine merge upstream

@cee-chen
Copy link
Contributor Author

cee-chen commented Nov 1, 2021

@elastic/kibana-app-services @elastic/kibana-presentation @elastic/kibana-reporting-services @elastic/kibana-vis-editors - heads up that I'm looking to merge this by EOD today, as it looks like the remaining affected files are snapshot-only.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #7 / dashboard feature controls dashboard feature controls security no dashboard privileges "before all" hook for "doesn't show dashboard navLink"
  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type float "is not" operator will return just 1 result we excluded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 922.9KB 922.9KB +1.0B
visTypeTable 15.9KB 15.7KB -184.0B
total -183.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 596.8KB 597.0KB +275.0B
kbnUiSharedDeps-npmDll 5.0MB 5.0MB -157.0B
total +118.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen enabled auto-merge (squash) November 1, 2021 20:43
@cee-chen cee-chen disabled auto-merge November 1, 2021 20:43
@cee-chen cee-chen merged commit 80ef314 into elastic:main Nov 1, 2021
@cee-chen cee-chen deleted the eui-40.1.0 branch November 1, 2021 21:31
@kibanamachine kibanamachine mentioned this pull request Nov 1, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 1, 2021
@VladLasitsa @kibanamachine
Upgrade to EUI v40.1.0 (elastic#116692)
4b2e8a5 
* Upgrade EUI to v40.1.0

* [Discover] Remove temp fix + update snapshot

* Fix deprecated `popperPlacement` prop

* Update test snapshots with table cell change

Co-authored-by: Uladzislau Lasitsa <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 1, 2021
@kibanamachine @VladLasitsa
Upgrade to EUI v40.1.0 (#116692) (#117037)
e414cb6 
* Upgrade EUI to v40.1.0

* [Discover] Remove temp fix + update snapshot

* Fix deprecated `popperPlacement` prop

* Update test snapshots with table cell change

Co-authored-by: Uladzislau Lasitsa <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Constance <[email protected]>
Co-authored-by: Uladzislau Lasitsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@spalger spalger spalger approved these changes

@matschaffer matschaffer matschaffer approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed EUI release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cee-chen @elasticmachine @kibanamachine @matschaffer @spalger @VladLasitsa