Upgrade to EUI v40.1.0 (#116692)

* Upgrade EUI to v40.1.0 * [Discover] Remove temp fix + update snapshot * Fix deprecated `popperPlacement` prop * Update test snapshots with table cell change Co-authored-by: Uladzislau Lasitsa <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
elastic · Nov 1, 2021 · 80ef314 · 80ef314
1 parent f5f1208
commit 80ef314
Show file tree

Hide file tree

Showing 10 changed files with 72 additions and 88 deletions.
diff --git a/package.json b/package.json
@@ -102,7 +102,7 @@
     "@elastic/datemath": "link:bazel-bin/packages/elastic-datemath",
     "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@^8.0.0-canary.35",
     "@elastic/ems-client": "8.0.0",
-    "@elastic/eui": "40.0.0",
+    "@elastic/eui": "40.1.0",
     "@elastic/filesaver": "1.1.2",
     "@elastic/maki": "6.3.0",
     "@elastic/node-crypto": "1.2.1",

diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts
@@ -75,6 +75,6 @@ export const LICENSE_OVERRIDES = {
   '[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
   '@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
   '@elastic/[email protected]': ['Elastic License 2.0'],
-  '@elastic/eui@40.0.0': ['SSPL-1.0 OR Elastic License 2.0'],
+  '@elastic/eui@40.1.0': ['SSPL-1.0 OR Elastic License 2.0'],
   '[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
 };
diff --git a/...s/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap b/...s/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap
diff --git a/..._editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap b/..._editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap
diff --git a/src/plugins/vis_types/table/public/components/__snapshots__/table_vis_basic.test.tsx.snap b/src/plugins/vis_types/table/public/components/__snapshots__/table_vis_basic.test.tsx.snap
diff --git a/src/plugins/vis_types/table/public/components/table_vis_basic.tsx b/src/plugins/vis_types/table/public/components/table_vis_basic.tsx
@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import React, { memo, useCallback, useMemo, useEffect, useState, useRef } from 'react';
+import React, { memo, useCallback, useMemo } from 'react';
 import { EuiDataGrid, EuiDataGridProps, EuiDataGridSorting, EuiTitle } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { orderBy } from 'lodash';
@@ -111,26 +111,6 @@ export const TableVisBasic = memo(
       [columns, setColumnsWidth]
     );
 
-    const firstRender = useRef(true);
-    const [dataGridUpdateCounter, setDataGridUpdateCounter] = useState(0);
-
-    // key was added as temporary solution to force re-render if we change autoFitRowToContent or we get new data
-    // cause we have problem with correct updating height cache in EUI datagrid when we use auto-height
-    // will be removed as soon as fix problem on EUI side
-    useEffect(() => {
-      // skip first render
-      if (firstRender.current) {
-        firstRender.current = false;
-        return;
-      }
-      // skip if auto height was turned off
-      if (!visConfig.autoFitRowToContent) {
-        return;
-      }
-      // update counter to remount grid from scratch
-      setDataGridUpdateCounter((counter) => counter + 1);
-    }, [visConfig.autoFitRowToContent, table, sort, pagination, columnsWidth]);
-
     return (
       <>
         {title && (
@@ -139,7 +119,6 @@ export const TableVisBasic = memo(
           </EuiTitle>
         )}
         <EuiDataGrid
-          key={String(dataGridUpdateCounter)}
           aria-label={dataGridAriaLabel}
           columns={gridColumns}
           gridStyle={{

diff --git a/...s/canvas/public/components/home/my_workpads/__snapshots__/workpad_table.stories.storyshot b/...s/canvas/public/components/home/my_workpads/__snapshots__/workpad_table.stories.storyshot
diff --git a/...gins/infra/public/pages/metrics/inventory_view/components/waffle/waffle_time_controls.tsx b/...gins/infra/public/pages/metrics/inventory_view/components/waffle/waffle_time_controls.tsx
@@ -65,7 +65,7 @@ export const WaffleTimeControls = withTheme(({ interval }: Props) => {
             injectTimes={currentMoment ? [currentMoment] : []}
             isLoading={isAutoReloading}
             onChange={handleChangeDate}
-            popperPlacement="top-end"
+            popoverPlacement="top-end"
             selected={currentMoment}
             shouldCloseOnSelect
             showTimeSelect