Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.16] Jest and Storybook fixes (#116132) #116689

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 28, 2021

Backports the following commits to 7.16:

* Fix all broken stories
* In stories that were broken, add an associated Jest test so they if they break in the future we'll know
* Fix all console.error messages that were being printed during Jest test runs
* Add test setup which makes it so `console.error` throws an error so tests will fail if error console messages are printed
# Conflicts:
#	x-pack/plugins/apm/public/components/shared/backend_link.stories.tsx
@smith smith added the backport label Oct 28, 2021
@smith smith enabled auto-merge (squash) October 28, 2021 16:45
@smith smith merged commit 14b5704 into elastic:7.16 Oct 28, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants