Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest and Storybook fixes #116132

Merged
merged 11 commits into from
Oct 26, 2021
Merged

Jest and Storybook fixes #116132

merged 11 commits into from
Oct 26, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 25, 2021 •
edited
Loading

  • Fix all broken stories
  • In stories that were broken, add an associated Jest test so they if they break in the future we'll know
  • Fix all console.error messages that were being printed during Jest test runs
  • Add test setup which makes it so console.error throws an error so tests will fail if error console messages are printed

@smith smith changed the title Inspector, Jest and Storybook fixes Jest and Storybook fixes Oct 25, 2021
@smith smith added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Oct 25, 2021
@smith smith marked this pull request as ready for review October 25, 2021 18:55
@smith smith requested a review from a team as a code owner October 25, 2021 18:55
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!! And I love seeing the number of lines deleted! Let's keep deleting unit tests if they don't provide enough value, and we'll have a really nice foundation of storybook + jest.

@smith
Copy link
Contributor Author

smith commented Oct 26, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 57c2555 into elastic:master Oct 26, 2021
@smith smith deleted the nls/jest-fix branch October 26, 2021 12:25
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 116132

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116132 or prevent reminders by adding the backport:skip label.

smith added a commit to smith/kibana that referenced this pull request Oct 28, 2021
@smith
Jest and Storybook fixes (elastic#116132)
2b25394 
* Fix all broken stories
* In stories that were broken, add an associated Jest test so they if they break in the future we'll know
* Fix all console.error messages that were being printed during Jest test runs
* Add test setup which makes it so `console.error` throws an error so tests will fail if error console messages are printed
# Conflicts:
#	x-pack/plugins/apm/public/components/shared/backend_link.stories.tsx
This was referenced Oct 28, 2021
Merged
Merged
smith added a commit to smith/kibana that referenced this pull request Oct 28, 2021
@smith
Jest and Storybook fixes (elastic#116132)
b79cd04 
* Fix all broken stories
* In stories that were broken, add an associated Jest test so they if they break in the future we'll know
* Fix all console.error messages that were being printed during Jest test runs
* Add test setup which makes it so `console.error` throws an error so tests will fail if error console messages are printed
# Conflicts:
#	x-pack/plugins/apm/public/components/shared/backend_link.stories.tsx
smith added a commit that referenced this pull request Oct 28, 2021
@smith
Jest and Storybook fixes (#116132) (#116689)
14b5704 
* Fix all broken stories
* In stories that were broken, add an associated Jest test so they if they break in the future we'll know
* Fix all console.error messages that were being printed during Jest test runs
* Add test setup which makes it so `console.error` throws an error so tests will fail if error console messages are printed
# Conflicts:
#	x-pack/plugins/apm/public/components/shared/backend_link.stories.tsx
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2021
smith added a commit that referenced this pull request Nov 1, 2021
@smith @kibanamachine
Jest and Storybook fixes (#116132) (#116688)
fe35e23 
* Fix all broken stories
* In stories that were broken, add an associated Jest test so they if they break in the future we'll know
* Fix all console.error messages that were being printed during Jest test runs
* Add test setup which makes it so `console.error` throws an error so tests will fail if error console messages are printed
# Conflicts:
#	x-pack/plugins/apm/public/components/shared/backend_link.stories.tsx

Co-authored-by: Kibana Machine <[email protected]>
@smith smith mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smith @elasticmachine @kibanamachine @sorenlouv