Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLEET] Increase asset size limit for installing ML model packages #115890

Merged
merged 3 commits into from
Oct 21, 2021
Merged

[FLEET] Increase asset size limit for installing ML model packages #115890

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
beceada
update size limit for assets to 50mb
alvarezmelissa87 Oct 20, 2021
d4d56ad
use different size limit for ml model
alvarezmelissa87 Oct 21, 2021
2706fd0
add byte constant for clarity
alvarezmelissa87 Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions x-pack/plugins/fleet/server/services/epm/archive/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,11 @@ import { getArchiveEntry, setArchiveEntry, setArchiveFilelist, setPackageInfo }
import type { ArchiveEntry } from './index';
import { parseAndVerifyPolicyTemplates, parseAndVerifyStreams } from './validation';

const ONE_BYTE = 1024 * 1024;
// could be anything, picked this from https://github.com/elastic/elastic-agent-client/issues/17
const MAX_ES_ASSET_BYTES = 4 * 1024 * 1024;
const MAX_ES_ASSET_BYTES = 4 * ONE_BYTE;
// Updated to accomodate larger package size in some ML model packages
const ML_MAX_ES_ASSET_BYTES = 50 * ONE_BYTE;

export interface PackageAsset {
package_name: string;
Expand Down Expand Up @@ -64,15 +67,20 @@ export async function archiveEntryToESDocument(opts: {
const bufferIsBinary = await isBinaryFile(buffer);
const dataUtf8 = bufferIsBinary ? '' : buffer.toString('utf8');
const dataBase64 = bufferIsBinary ? buffer.toString('base64') : '';
const currentMaxAssetBytes = path.includes('ml_model')
? ML_MAX_ES_ASSET_BYTES
: MAX_ES_ASSET_BYTES;

// validation: filesize? asset type? anything else
if (dataUtf8.length > MAX_ES_ASSET_BYTES) {
throw new Error(`File at ${path} is larger than maximum allowed size of ${MAX_ES_ASSET_BYTES}`);
if (dataUtf8.length > currentMaxAssetBytes) {
throw new Error(
`File at ${path} is larger than maximum allowed size of ${currentMaxAssetBytes}`
);
}

if (dataBase64.length > MAX_ES_ASSET_BYTES) {
if (dataBase64.length > currentMaxAssetBytes) {
throw new Error(
`After base64 encoding file at ${path} is larger than maximum allowed size of ${MAX_ES_ASSET_BYTES}`
`After base64 encoding file at ${path} is larger than maximum allowed size of ${currentMaxAssetBytes}`
);
}

Expand Down