[FLEET] Increase asset size limit for installing ML model packages #115890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
approved these changes
Oct 21, 2021
Comment on lines
32
to
35
| // could be anything, picked this from https://github.com/elastic/elastic-agent-client/issues/17 | ||
| const MAX_ES_ASSET_BYTES = 4 * 1024 * 1024; | ||
| // Updated to accomodate larger package size in some ML model packages | ||
| const ML_MAX_ES_ASSET_BYTES = 50 * 1024 * 1024; |
There was a problem hiding this comment.
nit: could we use a ONE_BYTE constant to make this more clear:
Suggested change
| // could be anything, picked this from https://github.com/elastic/elastic-agent-client/issues/17 | |
| const MAX_ES_ASSET_BYTES = 4 * 1024 * 1024; | |
| // Updated to accomodate larger package size in some ML model packages | |
| const ML_MAX_ES_ASSET_BYTES = 50 * 1024 * 1024; | |
| const ONE_BYTE = 1024 * 1024; | |
| // could be anything, picked this from https://github.com/elastic/elastic-agent-client/issues/17 | |
| const MAX_ES_ASSET_BYTES = 4 * ONE_BYTE; | |
| // Updated to accommodate larger package size in some ML model packages | |
| const ML_MAX_ES_ASSET_BYTES = 50 * ONE_BYTE; |
There was a problem hiding this comment.
Thanks for taking a look! 😄 Updated in 2706fd0
alvarezmelissa87
force-pushed
the
ml-models-in-fleet-increase-size-limit
branch
from
7c8e11a to
d4d56ad
Compare
alvarezmelissa87
added
:ml
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
added
release_note:enhancement
release_note:skip
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
shivindera
pushed a commit
to shivindera/kibana
that referenced
this pull request
Oct 25, 2021
…lastic#115890) * update size limit for assets to 50mb * use different size limit for ml model * add byte constant for clarity
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
peteharverson
added
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increases asset size limit for ML model packages.
This is a potentially temporary change to accommodate DGA model (which is about 45mb) installation - the 4mb limit is kept for all other asset types as per elastic/elastic-agent-client#17
This could be improved on in the future if necessary by making the limit an option to be passed in or other options discussed in the above issue.
Checklist
Delete any items that are not applicable to this PR.
For maintainers