Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip dashboard and dashboard panel a11y tests #115102

Merged
merged 16 commits into from
Oct 21, 2021
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/accessibility/apps/dashboard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const listingTable = getService('listingTable');

// FLAKY: https://github.com/elastic/kibana/issues/105171
describe.skip('Dashboard', () => {
describe('Dashboard', () => {
const dashboardName = 'Dashboard Listing A11y';
const clonedDashboardName = 'Dashboard Listing A11y Copy';

Expand Down
3 changes: 1 addition & 2 deletions test/accessibility/apps/dashboard_panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const inspector = getService('inspector');

// FLAKY: https://github.com/elastic/kibana/issues/112920
describe.skip('Dashboard Panel', () => {
describe('Dashboard Panel', () => {
before(async () => {
await PageObjects.common.navigateToApp('dashboard');
await testSubjects.click('dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard');
Expand Down
3 changes: 1 addition & 2 deletions test/accessibility/apps/discover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.saveCurrentSavedQuery();
});

// issue - https://github.com/elastic/kibana/issues/78488
it.skip('a11y test on saved queries list panel', async () => {
it('a11y test on saved queries list panel', async () => {
await PageObjects.discover.clickSavedQueriesPopOver();
await testSubjects.moveMouseTo(
'saved-query-list-item load-saved-query-test-button saved-query-list-item-selected saved-query-list-item-selected'
Expand Down
2 changes: 2 additions & 0 deletions test/accessibility/apps/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ export default function ({ getService, loadTestFile, getPageObjects }: FtrProvid
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
useActualUrl: true,
});
// await testSubjects.click('addSampleDataSetflights');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor cleanup to remove commented line

await PageObjects.home.addSampleDataSet('flights');
});

after(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
useActualUrl: true,
});
// await testSubjects.click('removeSampleDataSetflights');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another cleanup

await PageObjects.home.removeSampleDataSet('flights');
await kibanaServer.savedObjects.clean({
types: ['search', 'index-pattern', 'visualization', 'dashboard'],
Expand Down
7 changes: 6 additions & 1 deletion test/functional/page_objects/home_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export class HomePageObject extends FtrService {
private readonly retry = this.ctx.getService('retry');
private readonly find = this.ctx.getService('find');
private readonly common = this.ctx.getPageObject('common');
private readonly log = this.ctx.getService('log');

async clickSynopsis(title: string) {
await this.testSubjects.click(`homeSynopsisLink${title}`);
Expand All @@ -27,7 +28,11 @@ export class HomePageObject extends FtrService {
}

async isSampleDataSetInstalled(id: string) {
return !(await this.testSubjects.exists(`addSampleDataSet${id}`));
const sampleDataCard = await this.testSubjects.find(`sampleDataSetCard${id}`);
const sampleDataCardInnerHTML = await sampleDataCard.getAttribute('innerHTML');
this.log.debug(sampleDataCardInnerHTML);
return sampleDataCardInnerHTML.includes('removeSampleDataSet');
// return !(await this.testSubjects.exists(`addSampleDataSet${id}`));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another cleanup

}

async isWelcomeInterstitialDisplayed() {
Expand Down