-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip dashboard and dashboard panel a11y tests #115102
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
794e883
unskipping a11y tests and closing issues
bhavyarm c25ea9b
Merge branch 'master' into fixSkippedA11yTest
kibanamachine 986a0a4
Merge branch 'master' into fixSkippedA11yTest
bhavyarm 6cf68a6
removing skipped test issue comments from the test
bhavyarm 25cc6c4
Merge branch 'fixSkippedA11yTest' of github.com:bhavyarm/kibana into …
bhavyarm ac3a1eb
Merge branch 'master' into fixSkippedA11yTest
bhavyarm 4b37b5a
adding flights sample data directly to see if we can avoid flakiness
bhavyarm 2822131
Merge branch 'master' into fixSkippedA11yTest
bhavyarm ed60434
fixing the type error again
bhavyarm 00522b2
making sample data addition and removal more resilient
bhavyarm 9daf30f
fix the type error
bhavyarm 0a7307f
Merge branch 'master' into fixSkippedA11yTest
kibanamachine 714b700
Merge branch 'master' into fixSkippedA11yTest
bhavyarm 4b5f3b6
uncommenting commented tests
bhavyarm 743471c
removing unnecessary commented out code
bhavyarm 39b7409
Merge branch 'master' into fixSkippedA11yTest
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,13 +18,15 @@ export default function ({ getService, loadTestFile, getPageObjects }: FtrProvid | |
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', { | ||
useActualUrl: true, | ||
}); | ||
// await testSubjects.click('addSampleDataSetflights'); | ||
await PageObjects.home.addSampleDataSet('flights'); | ||
}); | ||
|
||
after(async () => { | ||
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', { | ||
useActualUrl: true, | ||
}); | ||
// await testSubjects.click('removeSampleDataSetflights'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. another cleanup |
||
await PageObjects.home.removeSampleDataSet('flights'); | ||
await kibanaServer.savedObjects.clean({ | ||
types: ['search', 'index-pattern', 'visualization', 'dashboard'], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ export class HomePageObject extends FtrService { | |
private readonly retry = this.ctx.getService('retry'); | ||
private readonly find = this.ctx.getService('find'); | ||
private readonly common = this.ctx.getPageObject('common'); | ||
private readonly log = this.ctx.getService('log'); | ||
|
||
async clickSynopsis(title: string) { | ||
await this.testSubjects.click(`homeSynopsisLink${title}`); | ||
|
@@ -27,7 +28,11 @@ export class HomePageObject extends FtrService { | |
} | ||
|
||
async isSampleDataSetInstalled(id: string) { | ||
return !(await this.testSubjects.exists(`addSampleDataSet${id}`)); | ||
const sampleDataCard = await this.testSubjects.find(`sampleDataSetCard${id}`); | ||
const sampleDataCardInnerHTML = await sampleDataCard.getAttribute('innerHTML'); | ||
this.log.debug(sampleDataCardInnerHTML); | ||
return sampleDataCardInnerHTML.includes('removeSampleDataSet'); | ||
// return !(await this.testSubjects.exists(`addSampleDataSet${id}`)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. another cleanup |
||
} | ||
|
||
async isWelcomeInterstitialDisplayed() { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor cleanup to remove commented line