Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip dashboard and dashboard panel a11y tests #115102

Merged
merged 16 commits into from
Oct 21, 2021
Merged

Unskip dashboard and dashboard panel a11y tests #115102

merged 16 commits into from
Oct 21, 2021

Conversation

bhavyarm
Copy link
Contributor

Unskipping skipped dashboard tests - #111234
And removing .skip from a passing a11y test on saved query

@bhavyarm bhavyarm self-assigned this Oct 14, 2021
@bhavyarm bhavyarm added v8.0.0 Project:Accessibility Feature:Dashboard Dashboard related features release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 14, 2021
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review October 15, 2021 16:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@bhavyarm bhavyarm added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 15, 2021
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 15, 2021 •
edited
Loading

So flaky test runner failed with index pattern not found screenshot - https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2027/ Going to discuss this with @LeeDr cc @1Copenut @rashmivkulkarni

Screen Shot 2021-10-15 at 12 22 33 PM

@bhavyarm bhavyarm removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 15, 2021
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 15, 2021
@bhavyarm bhavyarm added Team:QA Team label for QA Team and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 15, 2021
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

Flaky test run - https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2080/console

@bhavyarm bhavyarm requested a review from LeeDr October 20, 2021 22:44
LeeDr
LeeDr reviewed Oct 21, 2021
View reviewed changes
test/accessibility/apps/index.ts Outdated
@@ -18,13 +18,15 @@ export default function ({ getService, loadTestFile, getPageObjects }: FtrProvid
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
useActualUrl: true,
});
// await testSubjects.click('addSampleDataSetflights');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor cleanup to remove commented line

LeeDr
LeeDr reviewed Oct 21, 2021
View reviewed changes
test/accessibility/apps/index.ts Outdated
await PageObjects.home.addSampleDataSet('flights');
});

after(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
useActualUrl: true,
});
// await testSubjects.click('removeSampleDataSetflights');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another cleanup

LeeDr
LeeDr reviewed Oct 21, 2021
View reviewed changes
test/functional/page_objects/home_page.ts Outdated
const sampleDataCardInnerHTML = await sampleDataCard.getAttribute('innerHTML');
this.log.debug(sampleDataCardInnerHTML);
return sampleDataCardInnerHTML.includes('removeSampleDataSet');
// return !(await this.testSubjects.exists(`addSampleDataSet${id}`));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another cleanup

@bhavyarm
Copy link
Contributor Author

Another clean flaky test run with all the tests in the suite uncommented - https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2081/console

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #13 / console feature controls security no dev_tools privileges "before all" hook for "doesn't show 'Dev Tools' navLink"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

LeeDr
LeeDr approved these changes Oct 21, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and test results :-)

@bhavyarm bhavyarm merged commit c12554b into elastic:master Oct 21, 2021
@bhavyarm bhavyarm mentioned this pull request Oct 21, 2021
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Oct 21, 2021
@bhavyarm
Unskip dashboard and dashboard panel a11y tests (elastic#115102)
8870612
bhavyarm added a commit that referenced this pull request Oct 21, 2021
@bhavyarm
Unskip dashboard and dashboard panel a11y tests (#115102) (#115977)
2976efb
shivindera pushed a commit to shivindera/kibana that referenced this pull request Oct 25, 2021
@bhavyarm @shivindera
Unskip dashboard and dashboard panel a11y tests (elastic#115102)
5f9b239
@nreese nreese mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:QA Team label for QA Team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhavyarm @elasticmachine @kibanamachine @LeeDr