[data view mgmt] change urls from indexPatterns to dataViews

src/plugins/data_views/common/data_views/data_views.ts

@@ -423,11 +423,7 @@ export class DataViewsService {
     );
 
     if (!savedObject.version) {
-      throw new SavedObjectNotFound(
-        DATA_VIEW_SAVED_OBJECT_TYPE,
-        id,
-        'management/kibana/indexPatterns'
-      );
+      throw new SavedObjectNotFound(DATA_VIEW_SAVED_OBJECT_TYPE, id, 'management/kibana/dataViews');
     }
 
     return this.initFromSavedObject(savedObject);

src/plugins/data_views/public/data_views/redirect_no_index_pattern.tsx

@@ -22,7 +22,7 @@ export const onRedirectNoIndexPattern =
   ) =>
   () => {
     const canManageIndexPatterns = capabilities.management.kibana.indexPatterns;
-    const redirectTarget = canManageIndexPatterns ? '/management/kibana/indexPatterns' : '/home';
+    const redirectTarget = canManageIndexPatterns ? '/management/kibana/dataViews' : '/home';
     let timeoutId: NodeJS.Timeout | undefined;
 
     if (timeoutId) {

src/plugins/data_views/server/saved_objects/data_views.ts

@@ -23,11 +23,11 @@ export const dataViewSavedObjectType: SavedObjectsType = {
       return obj.attributes.title;
     },
     getEditUrl(obj) {
-      return `/management/kibana/indexPatterns/patterns/${encodeURIComponent(obj.id)}`;
+      return `/management/kibana/dataViews/dataView/${encodeURIComponent(obj.id)}`;
     },
     getInAppUrl(obj) {
       return {
-        path: `/app/management/kibana/indexPatterns/patterns/${encodeURIComponent(obj.id)}`,
+        path: `/app/management/kibana/dataViews/dataView/${encodeURIComponent(obj.id)}`,
         uiCapabilitiesPath: 'management.kibana.indexPatterns',
       };
     },

src/plugins/index_pattern_management/public/components/edit_index_pattern/create_edit_field/create_edit_field.tsx

@@ -45,7 +45,7 @@ export const CreateEditField = withRouter(
             name: undefined,
           } as unknown as IndexPatternField);
 
-    const url = `/patterns/${indexPattern.id}`;
+    const url = `/dataView/${indexPattern.id}`;
 
     if (mode === 'edit' && !spec) {
       const message = i18n.translate('indexPatternManagement.editDataView.scripted.noFieldLabel', {

src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/utils.test.ts

@@ -15,5 +15,5 @@ test('getPath() should encode "fieldName"', () => {
       { name: 'Memory: Allocated Bytes/sec' } as unknown as IndexPatternField,
       { id: 'id' } as unknown as IndexPattern
     )
-  ).toMatchInlineSnapshot(`"/patterns/id/field/Memory%3A%20Allocated%20Bytes%2Fsec"`);
+  ).toMatchInlineSnapshot(`"/dataView/id/field/Memory%3A%20Allocated%20Bytes%2Fsec"`);
 });

src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/utils.ts

@@ -102,7 +102,7 @@ export function getTabs(indexPattern: IndexPattern, fieldFilter: string) {
 }
 
 export function getPath(field: IndexPatternField, indexPattern: IndexPattern) {
-  return `/patterns/${indexPattern?.id}/field/${encodeURIComponent(field.name)}`;
+  return `/dataView/${indexPattern?.id}/field/${encodeURIComponent(field.name)}`;
 }
 
 const allTypesDropDown = i18n.translate(

src/plugins/index_pattern_management/public/management_app/mount_management_section.tsx

@@ -8,7 +8,7 @@
 
 import React from 'react';
 import ReactDOM from 'react-dom';
-import { Router, Switch, Route } from 'react-router-dom';
+import { Router, Switch, Route, Redirect } from 'react-router-dom';
 
 import { i18n } from '@kbn/i18n';
 import { I18nProvider } from '@kbn/i18n/react';
@@ -73,12 +73,13 @@ export async function mountManagementSection(
             <Route path={['/create']}>
               <IndexPatternTableWithRouter canSave={canSave} showCreateDialog={true} />
             </Route>
-            <Route path={['/patterns/:id/field/:fieldName', '/patterns/:id/create-field/']}>
+            <Route path={['/dataView/:id/field/:fieldName', '/dataView/:id/create-field/']}>
               <CreateEditFieldContainer />
             </Route>
-            <Route path={['/patterns/:id']}>
+            <Route path={['/dataView/:id']}>
               <EditIndexPatternContainer />
             </Route>
+            <Redirect path={'/patterns*'} to={'dataView*'} />
             <Route path={['/']}>
               <IndexPatternTableWithRouter canSave={canSave} />
             </Route>

src/plugins/index_pattern_management/public/plugin.ts

@@ -36,7 +36,7 @@ const sectionsHeader = i18n.translate('indexPatternManagement.dataView.sectionsH
   defaultMessage: 'Data Views',
 });
 
-const IPM_APP_ID = 'indexPatterns';
+const IPM_APP_ID = 'dataViews';
 
 export class IndexPatternManagementPlugin
   implements
@@ -72,6 +72,8 @@ export class IndexPatternManagementPlugin
       id: IPM_APP_ID,
       title: sectionsHeader,
       order: 0,
+      capabilitiesId: 'indexPatterns',
+      redirectFrom: 'kibana/indexPatterns',
       mount: async (params) => {
         const { mountManagementSection } = await import('./management_app');
 

src/plugins/management/public/components/management_app/management_router.tsx

@@ -7,7 +7,7 @@
  */
 
 import React, { memo } from 'react';
-import { Route, Router, Switch } from 'react-router-dom';
+import { Route, Router, Switch, Redirect } from 'react-router-dom';
 import { AppMountParameters, ChromeBreadcrumb, ScopedHistory } from 'kibana/public';
 import { ManagementAppWrapper } from '../management_app_wrapper';
 import { ManagementLandingPage } from '../landing';
@@ -43,6 +43,12 @@ export const ManagementRouter = memo(
               />
             ))
         )}
+        {sections.map((section) =>
+          section
+            .getAppsEnabled()
+            .filter((app) => app.redirectFrom)
+            .map((app) => <Redirect path={`/${app.redirectFrom}*`} to={`${app.basePath}*`} />)
+        )}
         <Route
           path={'/'}
           component={() => (

src/plugins/management/public/management_sections_service.ts

@@ -74,7 +74,11 @@ export class ManagementSectionsService {
       if (capabilities.management.hasOwnProperty(section.id)) {
         const sectionCapabilities = capabilities.management[section.id];
         section.apps.forEach((app) => {
-          if (sectionCapabilities.hasOwnProperty(app.id) && sectionCapabilities[app.id] !== true) {
+          const capabilitiesId = app.capabilitiesId || app.id;
+          if (
+            sectionCapabilities.hasOwnProperty(capabilitiesId) &&
+            sectionCapabilities[capabilitiesId] !== true
+          ) {
             app.disable();
           }
         });

src/plugins/management/public/types.ts

@@ -72,4 +72,6 @@ export interface CreateManagementItemArgs {
   order?: number;
   euiIconType?: string; // takes precedence over `icon` property.
   icon?: string; // URL to image file; fallback if no `euiIconType`
+  capabilitiesId?: string; // overrides app id
+  redirectFrom?: string; // redirects from an old app id to the current app id
 }

src/plugins/management/public/utils/management_item.ts

@@ -15,16 +15,29 @@ export class ManagementItem {
   public readonly order: number;
   public readonly euiIconType?: string;
   public readonly icon?: string;
+  public readonly capabilitiesId?: string;
+  public readonly redirectFrom?: string;
 
   public enabled: boolean = true;
 
-  constructor({ id, title, tip, order = 100, euiIconType, icon }: CreateManagementItemArgs) {
+  constructor({
+    id,
+    title,
+    tip,
+    order = 100,
+    euiIconType,
+    icon,
+    capabilitiesId,
+    redirectFrom,
+  }: CreateManagementItemArgs) {
     this.id = id;
     this.title = title;
     this.tip = tip;
     this.order = order;
     this.euiIconType = euiIconType;
     this.icon = icon;
+    this.capabilitiesId = capabilitiesId;
+    this.redirectFrom = redirectFrom;
   }
 
   disable() {

src/plugins/saved_objects_management/public/management_section/object_view/components/inspect.test.tsx

@@ -30,9 +30,9 @@ describe('Inspect component', () => {
         meta: {
           title: `MyIndexPattern*`,
           icon: 'indexPatternApp',
-          editUrl: '#/management/kibana/indexPatterns/patterns/1',
+          editUrl: '#/management/kibana/dataViews/dataView/1',
           inAppUrl: {
-            path: '/management/kibana/indexPatterns/patterns/1',
+            path: '/management/kibana/dataViews/dataView/1',
             uiCapabilitiesPath: 'management.kibana.indexPatterns',
           },
         },

src/plugins/saved_objects_management/public/management_section/object_view/saved_object_view.test.tsx

@@ -158,9 +158,9 @@ describe('SavedObjectEdition', () => {
       meta: {
         title: `MyIndexPattern*`,
         icon: 'indexPatternApp',
-        editUrl: '#/management/kibana/indexPatterns/patterns/1',
+        editUrl: '#/management/kibana/dataViews/dataView/1',
         inAppUrl: {
-          path: '/management/kibana/indexPatterns/patterns/1',
+          path: '/management/kibana/dataViews/dataView/1',
           uiCapabilitiesPath: 'management.kibana.indexPatterns',
         },
         hiddenType: false,
@@ -187,7 +187,7 @@ describe('SavedObjectEdition', () => {
     const headerComponent = component.find('Header');
     expect(headerComponent.prop('canViewInApp')).toBe(true);
     expect(headerComponent.prop('canDelete')).toBe(true);
-    expect(headerComponent.prop('viewUrl')).toEqual('/management/kibana/indexPatterns/patterns/1');
+    expect(headerComponent.prop('viewUrl')).toEqual('/management/kibana/dataViews/dataView/1');
     const inspectComponent = component.find('Inspect');
     expect(inspectComponent.prop('object')).toEqual(savedObjectItem);
   });
@@ -225,9 +225,9 @@ describe('SavedObjectEdition', () => {
       meta: {
         title: `MyIndexPattern*`,
         icon: 'indexPatternApp',
-        editUrl: '#/management/kibana/indexPatterns/patterns/1',
+        editUrl: '#/management/kibana/dataViews/dataView/1',
         inAppUrl: {
-          path: '/management/kibana/indexPatterns/patterns/1',
+          path: '/management/kibana/dataViews/dataView/1',
           uiCapabilitiesPath: 'management.kibana.indexPatterns',
         },
         hiddenType: false,

src/plugins/saved_objects_management/public/management_section/objects_table/components/relationships.test.tsx

@@ -74,9 +74,9 @@ describe('Relationships', () => {
         meta: {
           title: 'MyIndexPattern*',
           icon: 'indexPatternApp',
-          editUrl: '#/management/kibana/indexPatterns/patterns/1',
+          editUrl: '#/management/kibana/dataViews/dataView/1',
           inAppUrl: {
-            path: '/management/kibana/indexPatterns/patterns/1',
+            path: '/management/kibana/dataViews/dataView/1',
             uiCapabilitiesPath: 'management.kibana.indexPatterns',
           },
         },
@@ -111,10 +111,10 @@ describe('Relationships', () => {
             id: '1',
             relationship: 'child',
             meta: {
-              editUrl: '/management/kibana/indexPatterns/patterns/1',
+              editUrl: '/management/kibana/dataViews/dataView/1',
               icon: 'indexPatternApp',
               inAppUrl: {
-                path: '/app/management/kibana/indexPatterns/patterns/1',
+                path: '/app/management/kibana/dataViews/dataView/1',
                 uiCapabilitiesPath: 'management.kibana.indexPatterns',
               },
               title: 'My Index Pattern',
@@ -365,9 +365,9 @@ describe('Relationships', () => {
         meta: {
           title: 'MyIndexPattern*',
           icon: 'indexPatternApp',
-          editUrl: '#/management/kibana/indexPatterns/patterns/1',
+          editUrl: '#/management/kibana/dataViews/dataView/1',
           inAppUrl: {
-            path: '/management/kibana/indexPatterns/patterns/1',
+            path: '/management/kibana/dataViews/dataView/1',
             uiCapabilitiesPath: 'management.kibana.indexPatterns',
           },
         },

src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx

@@ -28,9 +28,9 @@ const defaultProps: TableProps = {
       meta: {
         title: `MyIndexPattern*`,
         icon: 'indexPatternApp',
-        editUrl: '#/management/kibana/indexPatterns/patterns/1',
+        editUrl: '#/management/kibana/dataViews/dataView/1',
         inAppUrl: {
-          path: '/management/kibana/indexPatterns/patterns/1',
+          path: '/management/kibana/dataViews/dataView/1',
           uiCapabilitiesPath: 'management.kibana.indexPatterns',
         },
       },
@@ -59,9 +59,9 @@ const defaultProps: TableProps = {
       meta: {
         title: `MyIndexPattern*`,
         icon: 'indexPatternApp',
-        editUrl: '#/management/kibana/indexPatterns/patterns/1',
+        editUrl: '#/management/kibana/dataViews/dataView/1',
         inAppUrl: {
-          path: '/management/kibana/indexPatterns/patterns/1',
+          path: '/management/kibana/dataViews/dataView/1',
           uiCapabilitiesPath: 'management.kibana.indexPatterns',
         },
       },

src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx

@@ -152,9 +152,9 @@ describe('SavedObjectsTable', () => {
           meta: {
             title: `MyIndexPattern*`,
             icon: 'indexPatternApp',
-            editUrl: '#/management/kibana/indexPatterns/patterns/1',
+            editUrl: '#/management/kibana/dataViews/dataView/1',
             inAppUrl: {
-              path: '/management/kibana/indexPatterns/patterns/1',
+              path: '/management/kibana/dataViews/dataView/1',
               uiCapabilitiesPath: 'management.kibana.indexPatterns',
             },
           },

test/api_integration/apis/saved_objects_management/find.ts

@@ -244,10 +244,9 @@ export default function ({ getService }: FtrProviderContext) {
               icon: 'indexPatternApp',
               title: 'saved_objects*',
               hiddenType: false,
-              editUrl:
-                '/management/kibana/indexPatterns/patterns/8963ca30-3224-11e8-a572-ffca06da1357',
+              editUrl: '/management/kibana/dataViews/dataView/8963ca30-3224-11e8-a572-ffca06da1357',
               inAppUrl: {
-                path: '/app/management/kibana/indexPatterns/patterns/8963ca30-3224-11e8-a572-ffca06da1357',
+                path: '/app/management/kibana/dataViews/dataView/8963ca30-3224-11e8-a572-ffca06da1357',
                 uiCapabilitiesPath: 'management.kibana.indexPatterns',
               },
               namespaceType: 'single',

test/api_integration/apis/saved_objects_management/relationships.ts

@@ -86,10 +86,9 @@ export default function ({ getService }: FtrProviderContext) {
             meta: {
               title: 'saved_objects*',
               icon: 'indexPatternApp',
-              editUrl:
-                '/management/kibana/indexPatterns/patterns/8963ca30-3224-11e8-a572-ffca06da1357',
+              editUrl: '/management/kibana/dataViews/dataView/8963ca30-3224-11e8-a572-ffca06da1357',
               inAppUrl: {
-                path: '/app/management/kibana/indexPatterns/patterns/8963ca30-3224-11e8-a572-ffca06da1357',
+                path: '/app/management/kibana/dataViews/dataView/8963ca30-3224-11e8-a572-ffca06da1357',
                 uiCapabilitiesPath: 'management.kibana.indexPatterns',
               },
               namespaceType: 'single',
@@ -128,10 +127,9 @@ export default function ({ getService }: FtrProviderContext) {
             meta: {
               icon: 'indexPatternApp',
               title: 'saved_objects*',
-              editUrl:
-                '/management/kibana/indexPatterns/patterns/8963ca30-3224-11e8-a572-ffca06da1357',
+              editUrl: '/management/kibana/dataViews/dataView/8963ca30-3224-11e8-a572-ffca06da1357',
               inAppUrl: {
-                path: '/app/management/kibana/indexPatterns/patterns/8963ca30-3224-11e8-a572-ffca06da1357',
+                path: '/app/management/kibana/dataViews/dataView/8963ca30-3224-11e8-a572-ffca06da1357',
                 uiCapabilitiesPath: 'management.kibana.indexPatterns',
               },
               namespaceType: 'single',

test/functional/apps/management/_index_pattern_create_delete.js

@@ -133,7 +133,7 @@ export default function ({ getService, getPageObjects }) {
         return retry.try(function tryingForTime() {
           return browser.getCurrentUrl().then(function (currentUrl) {
             log.debug('currentUrl = ' + currentUrl);
-            expect(currentUrl).to.contain('management/kibana/indexPatterns');
+            expect(currentUrl).to.contain('management/kibana/dataViews');
           });
         });
       });