[data view mgmt] change urls from indexPatterns to dataViews

[mattkime]

Summary

Changing data view management urls from indexPatterns to dataViews. Includes redirects for old urls.

[nreese]

maps changes LGTM

[stephmilovic]

LGTM! thanks @mattkime 🚀 🎸

[qn895]

ML changes LGTM 🎉

[stratoula]

KibanaVisEditors changes LGTM, I tested it locally and redirects seem to work fine :)

[stratoula]

nit: I think that this has been added by accident.

[flash1293]

This PR is introducing specific hacks for one use case in the otherwise generic management framework which I think is the wrong way to implement this.

what about keeping an “indexpattern” management app registered which, on mount, simply redirects to the dataviews app? This is how we solved this for forwarding legacy “app/kibana” calls to “app/dashboards”, “app/visualize” and so on.

See here: https://github.com/elastic/kibana/blob/master/src/plugins/url_forwarding/public/forward_app/forward_app.ts#L23

similar for the capabilities thing - maybe we should slightly extend the “app” definition here to allow a separate capability key which is not app.id ?

[mattkime]

@flash1293 We could do that but we'd need to devise a way to prevent the management app from being shown in the sidebar. What do you think?

I think I'd prefer to keep this as is until there are more instances of management redirects. This isn't a 'clean' way of doing things but its simpler than implementing a more generic solution.

[flash1293]

@mattkime Good point about hiding the redirect app, but I it's worth making redirects and capabilities under another id a concept of the ManagementApp - IMHO placing a little hack to get something done is fine as long as it's encapsulated in a plugin, but this is a cross-plugin mixture of responsibilities here which leads us down the wrong track. In terms of code changes it doesn't seem to be much more complex to add optional aliasPath and capabilitiesId props to the ManagementApp class and use them in the same way you placed data view specific workarounds in the current PR.

[Dosant]

Seems there are still quite a bunch of old URLs in code. Did you skip them intentionally to rely on redirect or were these overlooked?

[mattkime]

@Dosant Looks like you found a better way to find instances of these urls in the code base than I had used. I don't see a need to get all of them due to the redirects. I'd rather not expand the scope of this PR since I'm trying to get this merged by EOD tomorrow since I'm out next week. The additional urls could be addressed in a follow up.

[Dosant]

Tested that redirect works as expected. Also tested without needed mgmt capabilities.

only remark: #114912 (comment)

[kibanamachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 2b8747e
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
fileUpload	673.4KB	673.4KB	-4.0B
indexPatternManagement	77.1KB	77.2KB	+61.0B
management	8.9KB	9.0KB	+144.0B
maps	2.7MB	2.7MB	-4.0B
ml	3.6MB	3.6MB	-4.0B
securitySolution	4.6MB	4.6MB	-4.0B
stackAlerts	159.0KB	159.0KB	-4.0B
total			+185.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dataViews	38.0KB	38.0KB	-8.0B
indexPatternManagement	4.1KB	4.2KB	+59.0B
management	10.0KB	10.2KB	+165.0B
total			+216.0B

History

• 💚 Build #594 succeeded 6abdf99
• 💚 Build #573 succeeded 394f8b2
• 💚 Build #499 succeeded b9efa25
• 💔 Build #488 failed abc0f12
• 💔 Build #465 failed c346ef5
• 💔 Build #408 failed 31d3f80

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[flash1293]

LGTM, thanks for making these changes @mattkime ! Tested and both redirect and disabled capability works fine.