[ML] Using data views service for loading data views #113961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
jgowdyelastic
requested review from
alvarezmelissa87,
peteharverson and
walterra
jgowdyelastic
added
7.16 candidate
:ml
auto-backport
|
Pinging @elastic/ml-ui (:ml) |
|
@elasticmachine merge upstream |
18 tasks
...ata_frame_analytics/pages/analytics_management/components/action_clone/clone_action_name.tsx
Outdated
Show resolved
Hide resolved
...ta_frame_analytics/pages/analytics_management/components/action_delete/use_delete_action.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/edit_utils.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/util/field_types_utils.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_frame_analytics/index_patterns.ts
Outdated
Show resolved
Hide resolved
...ata_frame_analytics/pages/analytics_management/components/action_clone/clone_action_name.tsx
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
peteharverson
approved these changes
Oct 12, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
deleted the
using-data-views-service-for-searching-for-data-views
branch
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 13, 2021
* [ML] Using data views service for loading data views * removing more saved object client uses * removing IIndexPattern use * removing IndexPattern use * removing more depricated types * fixing teste * fixing index pattern loading * tiny refactor * fixing rollup index test * changes based on review * adding size to find calls Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 13, 2021
* [ML] Using data views service for loading data views * removing more saved object client uses * removing IIndexPattern use * removing IndexPattern use * removing more depricated types * fixing teste * fixing index pattern loading * tiny refactor * fixing rollup index test * changes based on review * adding size to find calls Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: James Gowdy <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91822
Related to #91715
Changes all cases client and server side where we were using the saved object client to load index patterns.
Removes all uses of types
IIndexPatternandIndexPatternin favour ofDataViewServer side, a new function
getDataViewsServicehas been added to the items available from the route guard for all routes and the shared services guard for all shared services.Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately