Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Use data views service for loading data views #124381

Closed
peteharverson opened this issue Feb 2, 2022 · 2 comments · Fixed by #131819
Closed

[ML] Transforms: Use data views service for loading data views #124381

peteharverson opened this issue Feb 2, 2022 · 2 comments · Fixed by #131819

Comments

@peteharverson
Copy link
Contributor

Part of #91715

There are a number of places where the Transform plugin is loading data views (index patterns) directly from the Saved Object API. This saved object usage should be replaced with the data views service.

See also #113961 for how this was achieved in the ml plugin.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@mattkime
Copy link
Contributor

mattkime commented Apr 5, 2022

I also found x-pack/plugins/data_visualizer/public/application/file_data_visualizer/components/import_view/import_view.js which I believe is also the responsibility of the ml team. It would be great to see these resolved in 8.3 as this one one of the remaining places where the data view saved object is being read directly.


I found index-patterns being loaded in these files but there may be others -
x-pack/plugins/transform/public/app/hooks/use_search_items/common.ts
x-pack/plugins/transform/public/app/services/es_index_service.ts
x-pack/plugins/transform/server/routes/api/transforms.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants