React beats instance view #113500
React beats instance view #113500
Conversation
matschaffer
added
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
| <RouteInit | ||
| path="/beats/beat/:instance" | ||
| component={BeatsInstancePage} | ||
| codePaths={[CODE_PATH_ELASTICSEARCH]} |
There was a problem hiding this comment.
Should this be CODE_PATH_BEATS (see angular component) ? It even looks like it's not used by the endpoint but maybe an intermediary component ?
There was a problem hiding this comment.
ooh, nice catch!
| ]; | ||
|
|
||
| return ( | ||
| <PageTemplate |
There was a problem hiding this comment.
I think I might update this to do conditional tabs on BeatsTemplate. Using PageTemplate directly here works fine since beats only has one tab, but other parts of stack monitoring will have multiple tabs so will need a different pattern.
Doesn't buy us a lot here, but mirrors the pattern used in logstash where it's a lot better than just calling PageTemplate directly.
| }, | ||
| { | ||
| }); | ||
| tabs.push({ |
There was a problem hiding this comment.
Borrowed the pattern from #113256 here
There was a problem hiding this comment.
This could even be extracted to its own func as it looks like a good candidate for a unit test :)
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @matschaffer |
* Add beat instance page * Fix beat instance tabs to match angular * Remove unused cluster prop on beats template * Fix breadcrumbs * Remove unused cluster prop * Use correct codepath * Switch beats instance back to use template Doesn't buy us a lot here, but mirrors the pattern used in logstash where it's a lot better than just calling PageTemplate directly. Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Add beat instance page * Fix beat instance tabs to match angular * Remove unused cluster prop on beats template * Fix breadcrumbs * Remove unused cluster prop * Use correct codepath * Switch beats instance back to use template Doesn't buy us a lot here, but mirrors the pattern used in logstash where it's a lot better than just calling PageTemplate directly. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Mat Schaffer <[email protected]>
Summary
React version of https://github.com/elastic/kibana/tree/master/x-pack/plugins/monitoring/public/views/beats/beat
For #111757
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers