[Stack Monitoring] Logstash migration #113256

phillipb · 2021-09-28T12:44:58Z

Summary

Migrate logstash pages. Fixes: #111759

elasticmachine · 2021-09-28T12:45:43Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

…ash-migration

matschaffer

Got a couple code process notes. Looks decent overall. I'll try to exercise it.

x-pack/plugins/monitoring/public/application/index.tsx

x-pack/plugins/monitoring/public/components/logstash/overview/index.d.ts

matschaffer · 2021-09-29T05:38:44Z

We should probably add the single node view as well, or remove the "fixes" from the description here

matschaffer · 2021-09-29T05:43:42Z

Looks like we're missing the pipeline stage version and flyout too

Great start though! I'd be fine ✅ once the basics (merge issue, "fixes" comment) are fixed up.

x-pack/plugins/monitoring/server/config.ts

…ash-migration

matschaffer · 2021-10-04T01:51:49Z

@elasticmachine merge upstream

matschaffer

Spotted a couple of issues. But we could potentially fix in a follow up.

x-pack/plugins/monitoring/public/application/pages/logstash/nodes.tsx

x-pack/plugins/monitoring/public/application/pages/logstash/logstash_template.tsx

x-pack/plugins/monitoring/public/application/pages/logstash/pipeline.tsx

klacabane · 2021-10-04T11:31:19Z

x-pack/plugins/monitoring/public/application/pages/logstash/pipelines.tsx

+    if (pageData === null) {
+      return null;
+    }
+    const { clusterStatus, pipelines } = pageData || {};


nit: the fallback to an empty object breaks line 74 when reading clusterStatus.versions. Can we make the initial pageData check more robust (or maybe null is enough) and get rid of fallbacks and conditionals in the following lines ?

…ash-migration

… into logstash-migration

…ash-migration

kibanamachine · 2021-10-06T03:10:56Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 18051a8
Storybooks Preview
Documentation Changes
Flaky suites:
- xpack-kibana-ciGroup6

Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/search/session·ts.apis search search session touched time updates when you poll on an search

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]                 │
[00:00:00]                   └-: apis
[00:00:00]                     └-> "before all" hook in "apis"
[00:00:00]                     └-: search
[00:00:00]                       └-> "before all" hook in "search"
[00:00:03]                       └-: search session
[00:00:03]                         └-> "before all" hook for "should fail to extend a nonexistent session"
[00:00:03]                         └-> should fail to extend a nonexistent session
[00:00:03]                           └-> "before each" hook: global before each for "should fail to extend a nonexistent session"
[00:00:03]                           │ proc [kibana] [2021-10-06T01:44:17.451+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:03]                           └- ✓ pass  (86ms) "apis search search session should fail to extend a nonexistent session"
[00:00:03]                         └-> should sync search ids into not persisted session
[00:00:03]                           └-> "before each" hook: global before each for "should sync search ids into not persisted session"
[00:00:03]                           │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:03]                           │ proc [kibana] [2021-10-06T01:44:17.612+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:03]                           │ debg --- retry.waitForWithTimeout error: expected 200 "OK", got 404 "Not Found"
[00:00:04]                           │ proc [kibana] [2021-10-06T01:44:18.180+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:04]                           │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:00:04]                           │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/FNJrU6RqSFq_3NiAmOHqrA] update_mapping [_doc]
[00:00:04]                           └- ✓ pass  (1.3s) "apis search search session should sync search ids into not persisted session"
[00:00:04]                         └-> should complete session when searches complete
[00:00:04]                           └-> "before each" hook: global before each for "should complete session when searches complete"
[00:00:05]                           │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:08]                           │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/FNJrU6RqSFq_3NiAmOHqrA] update_mapping [_doc]
[00:00:15]                           │ debg Waiting up to 5000ms for searches eventually complete and session gets into the complete state...
[00:00:15]                           └- ✓ pass  (11.2s) "apis search search session should complete session when searches complete"
[00:00:15]                         └-> touched time updates when you poll on an search
[00:00:15]                           └-> "before each" hook: global before each for "touched time updates when you poll on an search"
[00:00:15]                           │ debg Waiting up to 20000ms for search session created...
[00:00:15]                           │ proc [kibana] [2021-10-06T01:44:30.018+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:16]                           │ proc [kibana] [2021-10-06T01:44:30.599+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:19]                           └- ✖ fail: apis search search session touched time updates when you poll on an search
[00:00:19]                           │      Error: expected '2021-10-06T01:44:30.989Z' to be below 2021-10-06T01:44:30.989Z
[00:00:19]                           │       at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:00:19]                           │       at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:336:8)
[00:00:19]                           │       at Function.lessThan (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:531:15)
[00:00:19]                           │       at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
[00:00:19]                           │       at runMicrotasks (<anonymous>)
[00:00:19]                           │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:00:19]                           │       at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:00:19]                           │ 
[00:00:19]                           │

Stack Trace

Error: expected '2021-10-06T01:44:30.989Z' to be below 2021-10-06T01:44:30.989Z
    at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:336:8)
    at Function.lessThan (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:531:15)
    at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`monitoring`	631	640	+9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`monitoring`	1011.0KB	1.0MB	+34.0KB

History

💔 Build #158254 failed c555bba
💚 Build #158004 succeeded 2ea390a
💚 Build #157853 succeeded eb68708
💔 Build #157515 failed 02c3195
💔 Build #157501 failed 5b87458

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

matschaffer

I think we can go with this. I noticed a few code level tweaks that I put in phillipb#1 for you (just merge if you're cool with it).

The other weird thing I notices is that the pipeline view detail drawer re-opens after you hit the "X" then you have to click it again to close. Here's a recording:

Otherwise looks good to me and we can patch up weirdness as a followup I think.

kibanamachine · 2021-10-06T12:12:56Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Phillip Burch <[email protected]>

phillipb added 2 commits September 27, 2021 10:37

Migrate lots of logstash pages

1d52884

Fix merge

17cb4bc

phillipb requested a review from a team as a code owner September 28, 2021 12:44

phillipb requested review from a team September 28, 2021 12:44

phillipb added Epic: Stack Monitoring de-angularization Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0 labels Sep 28, 2021

phillipb added the release_note:skip Skip the PR/issue when compiling release notes label Sep 28, 2021

phillipb changed the title ~~Logstash migration~~ [Stack Monitoring] Logstash migration Sep 28, 2021

phillipb added 2 commits September 28, 2021 07:59

prettier

fd7f43c

Merge branch 'master' of https://github.com/elastic/kibana into logst…

ba9ffbe

…ash-migration

matschaffer reviewed Sep 29, 2021

View reviewed changes

x-pack/plugins/monitoring/public/application/index.tsx Outdated Show resolved Hide resolved

x-pack/plugins/monitoring/public/components/logstash/overview/index.d.ts Outdated Show resolved Hide resolved

matschaffer mentioned this pull request Sep 30, 2021

React beats instance view #113500

Merged

9 tasks

phillipb added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 30, 2021

Fix lint

d556309

phillipb force-pushed the logstash-migration branch from 871beae to d556309 Compare September 30, 2021 16:48

matschaffer reviewed Oct 1, 2021

View reviewed changes

x-pack/plugins/monitoring/server/config.ts Outdated Show resolved Hide resolved

phillipb added 2 commits October 1, 2021 16:26

Merge branch 'master' of https://github.com/elastic/kibana into logst…

4dbe5f2

…ash-migration

Turn off react test

7d54ed3

Merge branch 'master' into logstash-migration

7d5b9b9

matschaffer reviewed Oct 4, 2021

View reviewed changes

klacabane reviewed Oct 4, 2021

View reviewed changes

phillipb added 2 commits October 4, 2021 07:38

Fix some lint stuff

7405f92

Merge branch 'master' of https://github.com/elastic/kibana into logst…

463cf15

…ash-migration

phillipb added 7 commits October 4, 2021 07:38

Merge branch 'logstash-migration' of https://github.com/phillipb/kibana…

5b87458

… into logstash-migration

Fix types

02c3195

Fix lint

eb68708

Add in version switcher

7e7adc8

Add version switcher

ce3e814

Merge branch 'logstash-migration' of https://github.com/phillipb/kibana…

13faa4f

… into logstash-migration

turn off react app

2ea390a

phillipb requested a review from matschaffer October 5, 2021 14:14

phillipb added 2 commits October 5, 2021 19:15

Merge branch 'master' of https://github.com/elastic/kibana into logst…

c555bba

…ash-migration

Fix lint

18051a8

matschaffer mentioned this pull request Oct 6, 2021

Review: [Stack Monitoring] Logstash migration phillipb/kibana#1

Closed

2 tasks

matschaffer approved these changes Oct 6, 2021

View reviewed changes

phillipb merged commit 7c27822 into elastic:master Oct 6, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021

[Stack Monitoring] Logstash migration (elastic#113256)

e22978d

kibanamachine mentioned this pull request Oct 6, 2021

[7.x] [Stack Monitoring] Logstash migration (#113256) #114091

Merged

kibanamachine added a commit that referenced this pull request Oct 6, 2021

[Stack Monitoring] Logstash migration (#113256) (#114091)

2284304

Co-authored-by: Phillip Burch <[email protected]>

matschaffer mentioned this pull request Oct 7, 2021

Logstash view cleanup fixes #114218

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Stack Monitoring] Logstash migration #113256

[Stack Monitoring] Logstash migration #113256

phillipb commented Sep 28, 2021 •

edited

Loading

elasticmachine commented Sep 28, 2021

matschaffer left a comment

matschaffer commented Sep 29, 2021

matschaffer commented Sep 29, 2021

matschaffer commented Oct 4, 2021

matschaffer left a comment

klacabane Oct 4, 2021

kibanamachine commented Oct 6, 2021

Standard Out

Stack Trace

matschaffer left a comment

kibanamachine commented Oct 6, 2021

[Stack Monitoring] Logstash migration #113256

[Stack Monitoring] Logstash migration #113256

Conversation

phillipb commented Sep 28, 2021 • edited Loading

Summary

elasticmachine commented Sep 28, 2021

matschaffer left a comment

Choose a reason for hiding this comment

matschaffer commented Sep 29, 2021

matschaffer commented Sep 29, 2021

matschaffer commented Oct 4, 2021

matschaffer left a comment

Choose a reason for hiding this comment

klacabane Oct 4, 2021

Choose a reason for hiding this comment

kibanamachine commented Oct 6, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

History

matschaffer left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 6, 2021

💚 Backport successful

phillipb commented Sep 28, 2021 •

edited

Loading