Use kibana_system user for Fleet setup and package operations #112808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2021
|
The functional tests that are failing on this PR are blocked by our Elasticsearch snapshot being promoted to a more recent build. I've pinged the appropriate teams to make sure we can get that promoted ASAP. The job that verifies the snapshot promotion is here: https://buildkite.com/elastic/kibana-elasticsearch-snapshot-verify |
joshdover
commented
Oct 11, 2021
Comment on lines
+112
to
+116
| export const getFileHandler: FleetRequestHandler<TypeOf<typeof GetFileRequestSchema.params>> = | ||
| async (context, request, response) => { | ||
| try { | ||
| const { pkgName, pkgVersion, filePath } = request.params; | ||
| const savedObjectsClient = context.fleet.epm.internalSoClient; |
There was a problem hiding this comment.
Only changes on this function are the change to FleetRequestHandler type and using internalSoClient instead of the current user one. Everything else is the same, but got re-formatted by the linter.
joshdover
commented
Oct 11, 2021
Comment on lines
+186
to
+190
| export const getInfoHandler: FleetRequestHandler<TypeOf<typeof GetInfoRequestSchema.params>> = | ||
| async (context, request, response) => { | ||
| try { | ||
| const { pkgkey } = request.params; | ||
| const savedObjectsClient = context.fleet.epm.internalSoClient; |
There was a problem hiding this comment.
Same here as well
joshdover
added
release_note:skip
|
Test failures are waiting on the next Elasticsearch snapshot to be promoted, otherwise, this is ready for review |
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
kpollich
approved these changes
Oct 11, 2021
criamico
approved these changes
Oct 12, 2021
|
CI will fail until elastic/elasticsearch#79076 is merged and Kibana's CI snapshot has been bumped |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_threat_matching·ts.detection engine api security and spaces enabled create_threat_matching tests with auditbeat data should be able to execute and get 10 signals when doing a specific queryStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Unrelated flaky test, merging. |
joshdover
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2021
…c#112808) Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2021
… (#115165) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Josh Dover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #111755
Blocked by:
Uses the
kibana_systemuser under the hood for executing all package installation operations. No external behavior changes are expected from this change.Because transforms require read and create_index privileges and we can't give kibana_system access to all indices, we no longer support arbitrary transforms. They specifically need privileges granted to kibana_system in the Elasticsearch codebase to work. Therefore, the transforms in our test package no longer work. I've removed these transforms and added tests specific to the only package we currently support this in, endpoint.
Checklist
Delete any items that are not applicable to this PR.
For maintainers