-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow elastic/fleet-server to call appropriate Fleet APIs #113932
Conversation
f759be3
to
1a562cd
Compare
@elasticmachine merge upstream |
merge conflict between base and head |
6aef69d
to
bf4139c
Compare
@elastic/kibana-security Would you mind reviewing the first commit? I'm still working on the rest but the first commit shall remain unchanged. Previously discussed here: #112647 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/kibana-security Would you mind reviewing the first commit? I'm still working on the rest but the first commit shall remain unchanged. Previously discussed here: #112647 (comment)
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the testing instructions and all looks good with the code for me. 🚀
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - invalid, too many tokens.Standard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…115533) Co-authored-by: Josh Dover <[email protected]>
Summary
Fixes #112647
First commit is ready for review from @elastic/kibana-security
Allows the
elastic/fleet-server
user to call the required Fleet APIs to trigger the full setup process. This will be removed as part of #111858.Fleet reviewers: you may skip the first commit if you'd like. It's a required change in the security plugin that has already been approved.
How to test this
The appropriate support for this available across all components now and this is the last piece. You can now test this end-to-end by:
Checklist
Delete any items that are not applicable to this PR.
For maintainers