-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] [Synthetics integration] browser monitors - Zip Url - add TLS Options and Proxy Url #112554
[Uptime] [Synthetics integration] browser monitors - Zip Url - add TLS Options and Proxy Url #112554
Conversation
…2-synthetics-integration-browser-tls
@elasticmachine merge upstream |
…ttps://github.com/dominiqueclarke/kibana into feature/111482-synthetics-integration-browser-tls
htmlIdGenerator: () => () => `id-${Math.random()}`, | ||
})); | ||
|
||
jest.mock('../../../../../../../src/plugins/kibana_react/public', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on creating a jest setup file? I've noticed we tend not to use them in favor of helpers that are imported where they are needed. I've actually ran into some problems with transitioning this mock to a helper function, and the only thing that has worked thus far has been including it inline in a jest setup file.
There are some things that we are likely to always mock, like the Monaco Code Editor, Canvas, and the htmlIdGenerator. Thoughts?
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
…2-synthetics-integration-browser-tls
…ttps://github.com/dominiqueclarke/kibana into feature/111482-synthetics-integration-browser-tls
…2-synthetics-integration-browser-tls
…2-synthetics-integration-browser-tls
@elasticmachine merge upstream |
…ttps://github.com/dominiqueclarke/kibana into feature/111482-synthetics-integration-browser-tls
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from design and product perspective. Ship it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally, works as expected. LGTM.
...original, | ||
// Mocking CodeEditor, which uses React Monaco under the hood | ||
CodeEditor: (props: any) => ( | ||
<input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 🥇
…S Options and Proxy Url (elastic#112554) * add tls options to browser monitors when zip url is selected * adjust types * add tests * refactor tls fields and zip url tls fields * adjust types * adjust i18n * add proxy url Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…S Options and Proxy Url (#112554) (#115080) * add tls options to browser monitors when zip url is selected * adjust types * add tests * refactor tls fields and zip url tls fields * adjust types * adjust i18n * add proxy url Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>
E2E testing not yet available
Resolves #111482
Adds TLS options for browser monitors when zip url is selected.
Testing
Setting up your e2e testing environment
Overview: You will need to run a local version of kibana and package registry to test pending changes, but will use
elastic-package
to run a snapshot view of elasticsearch, fleet-server, and elastic-agent. Since fleet server relies on kibana, we'll also useelastic-package
to start a snapshot view of kibana exclusively for bootstrapping fleet-server, but will point our local version of kibana to a separate port. So we'll be running two versions of Kibana.kibana.dev.yml
settings, add removekibana.index
andxpack.task_manager.index
to remove legacy multitenancy features. This ensures that both our instances of Kibana can share saved objects related to fleet and agent. Also, add the following keys:env BUILD_TS_REFS_DISABLE=true yarn kbn bootstrap && yarn start
go get github.com/elastic/elastic-package
packages/synthetics
in the repo directory. Runelastic-package clean
, thenelastic-package build
.elastic-package stack up -d -v --services "elasticsearch,fleet-server,elastic-agent,package-registry" --version 8.0.0-SNAPSHOT
in thepackages/synthetics
directory. This will start up elasticsearch, fleet-server, elastic-agent, package registry AND kibana. This is because fleet-server requires kibana for bootstrapping.kibana_system
usercurl -u elastic:changeme -X POST "http://localhost:9200/_security/user/kibana_system/_password?pretty" -H 'Content-Type: application/json' -d' { "password" : "changeme" } '
Testing TLS
fleet/integrations/synthetics-0.3.1/add-integration
https://github.com/elastic/synthetics-demo/archive/refs/heads/main.zip
, foldertodos/synthetics
, params{ "url": "https://elastic.github.io/synthetics-demo/" }
Enable tls options for ZIP URL
. Remove all the version options from the ssl version combo box and addTLSv1.0
. This will force the zip url to be fetched with an unsupported version.5. Save the integration and navigate to Uptime 6. Verify that the journey was not ran and data is not indexed into ES.